From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4373EC433EF for ; Thu, 30 Sep 2021 10:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D2E361881 for ; Thu, 30 Sep 2021 10:26:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349944AbhI3K2A (ORCPT ); Thu, 30 Sep 2021 06:28:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349927AbhI3K16 (ORCPT ); Thu, 30 Sep 2021 06:27:58 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF76DC06176A; Thu, 30 Sep 2021 03:26:15 -0700 (PDT) Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9AD92801B2; Thu, 30 Sep 2021 12:26:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632997573; bh=t0ZAB0+QCDlyECVZAwB2kSA+pHaEK0PNa4Y+jmVbIzk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=W6elItkTo4yl2NY99JNjb0LKjmj3yeTZi8CbYf8Z6Aqse7JMoNoC575rQfTsi8xhI LSRQljKpZWHWpX40cGR4wGXx2qRkivRqt7AIObQJdoqY+ylc/F+V6Oqm1vmOSSkfF2 tvlwD67NiNMP25tpyqGRUiE33FswVye54B4f9sOnDZe5MiI8xvTY0MuTmlzE5/07Y1 steTKiwAHgI51il/9AotmfBQ+iWGFr1iZRX5624Mga0jQGPdv+uIBSnpYZFCpTCvjq RlWcPd9Nb+azD3yExHigWeAoaisILpJAFwog4NZNZzck2mCqci2JKRMxBQE0XtW478 wYpJxt7+1q5+A== Subject: Re: [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15 To: Alexandre TORGUE , Olivier Moysan , Maxime Coquelin , Rob Herring Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20210927114553.21843-1-olivier.moysan@foss.st.com> From: Marek Vasut Message-ID: Date: Thu, 30 Sep 2021 12:26:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/21 10:47 AM, Alexandre TORGUE wrote: > Hi Marek > > On 9/29/21 1:18 PM, Marek Vasut wrote: >> On 9/27/21 1:45 PM, Olivier Moysan wrote: >>> Fix SAI2B pin muxing for AV96 board on STM32MP15. >>> The label "sai2a-4" is defined twice. Change redundant label to >>> "sai2b-4". >>> >>> Fixes: dcf185ca8175 ("ARM: dts: stm32: Add alternate pinmux for SAI2 >>> pins on stm32mp15") >>> >>> Signed-off-by: Olivier Moysan >>> --- >>>   arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>> b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>> index 5b60ecbd718f..b9cc9e0dd4fc 100644 >>> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>> @@ -1235,7 +1235,7 @@ >>>           }; >>>       }; >>> -    sai2b_pins_c: sai2a-4 { >>> +    sai2b_pins_c: sai2b-4 { >>>           pins1 { >>>               pinmux = ; /* SAI2_SD_B */ >>>               bias-disable; >> >> This mp1 pinmuxing is a total mess, sigh. > > What is the issue here ? The same-old discussion about where to place the pinmux nodes, whether we should have these clusters of pre-defined options in ...pinctrl.dtsi, or whether we should do more nxp-like per-board configuration.