mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Matthieu Baerts <matttbe@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Neal Cardwell <ncardwell@google.com>
Cc: mptcp@lists.linux.dev, "David S. Miller" <davem@davemloft.net>,
	David Ahern <dsahern@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Kuniyuki Iwashima <kuniyu@amazon.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] tcp: process the 3rd ACK with sk_socket for for TFO/MPTCP
Date: Thu, 18 Jul 2024 11:17:37 +0200	[thread overview]
Message-ID: <cfc3ba0a-4c91-4c58-9c98-6285720473c8@redhat.com> (raw)
In-Reply-To: <310de142-e263-4bcd-b499-69e0640de51e@kernel.org>

On 7/17/24 17:09, Matthieu Baerts wrote:
> On 17/07/2024 16:57, Eric Dumazet wrote:
>> I had no time yet to run all our packetdrill tests with Kuniyuki patch
>> because of the ongoing netdev conference.
>>
>> Is it ok for you if we hold your patch for about 5 days ?
> 
> Sure, no problem, take your time!
> 
>> I would like to make sure we did not miss anything else.
> 
> I understand!
> 
>> I am CCing Neal, perhaps he can help to expedite the testing part
>> while I am busy.
> 
> Thank you, no urgency here.
> 
> If it's OK with you, I can send a v2 using Kuniyuki's suggestion --
> simply limiting the bypass to SYN+ACK only -- because it is simpler and
> ready to be sent, but also to please the CI because my v1 was rejected
> by the CI because I sent it just before the sync with Linus tree. We can
> choose later to pick the v2, the previous one, or a future one.

I think it would be better to have this patch going through the netdev 
CI, so a repost would be appreciated. I also thing Kuniyuki's suggestion 
should be preferred, so I would say go for it :)

@Neal could you please run the pktdrill tests on the new, upcoming 
version, instead?

Thanks,

Paolo


      reply	other threads:[~2024-07-18  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 19:43 Matthieu Baerts (NGI0)
2024-07-17 14:57 ` Eric Dumazet
2024-07-17 15:09   ` Matthieu Baerts
2024-07-18  9:17     ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfc3ba0a-4c91-4c58-9c98-6285720473c8@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®