From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 647BF1420DD for ; Mon, 21 Jul 2025 13:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753105900; cv=none; b=uS5uDV4waeQ1YJR0xQnpwZZ76i9z0k7ZAdCVmhdR/uE/Ij1cOfb3Q4gJ+aJPC2RkHDiPW4xlFLcI/B38PtKV/DXsuN2Pt8xJcEXS31xgrObXXRyT9AED7omPawBKZAf71ieBWBH/yasow0KFBj2PBXaOrzoKYunZYN59CjTT/KI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753105900; c=relaxed/simple; bh=oq9WSvjlNctAjhJsmZyYP9dGzIiEdvMi+41B8vjBpNI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YODUFCP0VC0RzQ03GLBkxvYo7DnYzxCsUyuznhw6ejEQeyPkUDtZsigMOWxPvfbV2DPSUDkIaqH5Acb5cSrYa0vFaYlsNNf8JVwGjjYUKGANmad/03BkZr63S9sNnDVnaaU9HJeXEcZkFQHiLjjUaiADo0u6Fjb1BLbpOE9xWAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=IN3XoMJw; arc=none smtp.client-ip=209.85.160.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="IN3XoMJw" Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4ab644b8dc1so48560491cf.1 for ; Mon, 21 Jul 2025 06:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1753105897; x=1753710697; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6jHD16eTa4CvB7iarYQoWOJQjHRnWLktNHVHGBkrL7M=; b=IN3XoMJwwZdH1cfpNlQeUx0+b+eeQeUNrBc70tF8SLTAj7/CHksBAlyPLK1v0HP4A5 ahKLk7zmJeDZ+rM4bE/HQXqQMWEpQOIZovP31LaqbqGrxbqd7aXF51cLHY1z3YuNFK/S JjUsERMeDsZtje6bn6567iPGFLj9SWs84QMiABVoF6QtD55i4gAT7mq9FkErlS/+yAXx 72ynbq1k2oJtwn0EGzXpiOv1CLayDbGxf6oT2Z2hUZMiqPaVtUk0lbBZ9ykjfN9DAM7Q Y2LVhJDrP3AgFnsy7BXsjPpgzn3x3SqzXqrpale77/ntY8H3DoPLn8HrP7qeGDVtDq5W kP3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753105897; x=1753710697; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6jHD16eTa4CvB7iarYQoWOJQjHRnWLktNHVHGBkrL7M=; b=q8Iwl8BjJduerPjrqUjimFGZg8vSWWO/8E0ne13Rgze8+hON8iJBLgU6MXJeoh+F73 k+Y8Wjl9A9tyGPPnrS2ver/w1P1lQLHVfpmZ8AyhDx76R2H4APVvsKCloan0yfUCU5wf qlEm/+zNvzYVcjBmtRImGD3ms8h7kDEgwwS4wdf90RZC+JL+8caPZJYHERMo+t67C1Ra YCVpYMANE5E5rCMoYGjwjPn9sGCYlhP45S5C6k6t4ryDAQf6dENjZ3He24pdgm4qd2xP ePATx767j4EaWgvBHGs5LMvoTQpKd7yDAETpNbDOtnpJjSTMt4OI472BpFWxKVGhIUgU /zow== X-Forwarded-Encrypted: i=1; AJvYcCUTUMRvgt9k75Qv49impRdSH2FJiwLhX17cJmDUDG3geJ1+nMHKB4p59U5168+rRdGyL/0wHJ4nUK7YS88=@vger.kernel.org X-Gm-Message-State: AOJu0YxXeG9fYztl17VSbPHk4Wrwu4AfgobbTfPFINWdREIgxOEHDgWO wxKXTkLYd1G9vHbGG4GAGQMgYV9T6D4NgAKYSRM6Ta+z2vw6JmFEJ7MlVfe0VNK4mA== X-Gm-Gg: ASbGncsPSIsc4vxBrLNLOfurCYB7N55F/MNhoqVyOYgUAdER5vhuax46t9f6d5bRdSn Q/rpN/tJlE7Znn50y533cEdWx3B5lZu8F+WotASSdpInAKNC6dUEzLHCicanTnQ/k21UTLLeMr3 uB21PpO4qBFIvvk/Fu1XrMk7ygn5BO0Q7HkMKgnccdo6fbmQLVV/pNASQQcinAT3pBH1MULHTti ks3RJv4Es5r6DYgVACGgvX1SOPw9jHHQDEnM+VKxlN2eskhJCRLom4bOLtiTqO1FwcS+cnhT1pb txSTeP4O4L6RhTAbr3Zcn6ICD2abCT0eGH3kWgV1wlApYwqvFTeG5UzQwG585CY3/i3rox6jpZj j7R2j/ELQWl83Um4NVWsvfepBzibWGxRCHmzPemwk X-Google-Smtp-Source: AGHT+IFSGK8XaIApqm9eeGcRZ0wxc+1dTGf3tk1r5ZOtue7S6cIH3bFI6m87yeMDx9NaR1Ch2jGK4w== X-Received: by 2002:a05:622a:7b12:b0:4a9:91b7:6b88 with SMTP id d75a77b69052e-4ab93c6f807mr225423791cf.11.1753105897141; Mon, 21 Jul 2025 06:51:37 -0700 (PDT) Received: from rowland.harvard.edu ([140.247.181.15]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7051b8bc2dasm39329676d6.12.2025.07.21.06.51.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jul 2025 06:51:36 -0700 (PDT) Date: Mon, 21 Jul 2025 09:51:34 -0400 From: Alan Stern To: "Lecomte, Arnaud" Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, snovitoll@gmail.com, syzbot+86b6d7c8bcc66747c505@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH] usb: mon: Fix slab-out-of-bounds in mon_bin_event due to unsafe URB transfer_buffer access Message-ID: References: <20250720200057.19720-1-contact@arnaud-lcm.com> <8bbc84ee-44c9-4a85-b5bf-3980b3c81e5c@rowland.harvard.edu> <6cd8b6bd-d07b-404c-af23-42fcae9ed9df@arnaud-lcm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6cd8b6bd-d07b-404c-af23-42fcae9ed9df@arnaud-lcm.com> On Mon, Jul 21, 2025 at 09:22:40AM +0100, Lecomte, Arnaud wrote: > Hi Alan, thanks for your reply. > > Your point raises an important question for me: Is there a specific reason > why we don’t have >  a synchronization mechanism in place to protect the URB's transfer buffer ? Protect it from what? Access by some driver at an inappropriate time? Drivers are supposed to know (and this is alluded to in the kerneldoc for usb_submit_urb()) that they aren't allowed to touch the transfer buffer while an URB is queued. Alan Stern