From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755505AbdEHPKD (ORCPT ); Mon, 8 May 2017 11:10:03 -0400 Received: from mout.web.de ([217.72.192.78]:53404 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755210AbdEHPKB (ORCPT ); Mon, 8 May 2017 11:10:01 -0400 Subject: [PATCH 2/3] mtdswap: Improve two size determinations in mtdswap_add_mtd() From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger Cc: LKML , kernel-janitors@vger.kernel.org References: <82e905b5-3958-be81-b0ee-d0a2805154df@users.sourceforge.net> Message-ID: Date: Mon, 8 May 2017 17:09:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <82e905b5-3958-be81-b0ee-d0a2805154df@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:vWCq3OaGXSrn100Hgzqk1a752qVCUbPLodBeBsz/DCyaYsRwJ37 mkuMhK/UybEWOUjsoaVAneyx1gHcOSvKFoQLI4MqrIwDLjGBCFz8tImhMp2lo0BRNa3G/Zk E54u7rJVzFOfWWJK2/2BnLm6VLriyqPU1kkSOSxqRCH4ibI0djZRmEb07YRa5/clgGITxmq RvUfX6kUSrrn3WqfMfXrw== X-UI-Out-Filterresults: notjunk:1;V01:K0:l6tx3Fq92eA=:WkWYggZIyBdA2JwO5vhA62 BgSEiI0mEFHDIk3ZQ1s/heAIpLj7SzcZBRWxLegwgC9+lKLNsMlcGmkVDhMEkAEksepm5N7yV 1TH3ajX2n7ogfykHg3+JIqVau/35Sj1aXwr/alMUK7rcGCQJq8Zmg79TPXT/wtKM07MxVLBKU F35MNfoICaJ2G0SDSgpWGNNHryYMjL0YTTD8jDGtP/xSB9NFfkcRFnHxxUXpaUwor5lD3hYzC jUEXt5ZTQwtRmAOkmBADsu6afOWOdsgWCxosNdq/Rfv74AO3yA3mnVXIoJH/c6PMZEaMLjpWf 4C9kObI9Zp3hj0L6xoXs8p1IlkCYkHT2XAFq1EUblnJy6XNckV6w4ydeu474MxT411H/Ks80i BVIZCpaDKuRwywGPU2c+2delqzyrGqmRgiAnXMBdvopHLGc+BSXUWIOR9VXbjG7nS53uwIqbA TQjpmyGw+QSK5qceIfhz0a9lWnH02AK4yRha9eiIZZGiecwMGxLDbex/oy8XUR4p+8SlbP9VK 0sgHyIViw/9nqc8sTQZ3nZWJIC2IXopAxP+gBrbhgwkQmeBwZ5QLLBke4SI424dTRH7d5nQfG hX2GUpw8kdHce/hZ+DMzUioh8+5tanDCAcqZG8PFywmyA5CBnQC5SmcNG+e6vxjExffJSZDTr EI0koj+NY072Wje60g86MzEkmAqeRODoJEG08npgAkwPwK136+Y3JpkvDpYX9LKaBCAqYcei7 k2uJX99Mcl5uUhZu9iP6X5VrOHXgZ/ilDvQJwWFL5cb2Hdqx6F9K6Bwc+RMS5fRcJhAUCmWnI Ipe7Xfc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 8 May 2017 16:18:49 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/mtdswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index 0805f45c5139..f73fb0909b0c 100644 --- a/drivers/mtd/mtdswap.c +++ b/drivers/mtd/mtdswap.c @@ -1485,11 +1485,11 @@ static void mtdswap_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) "%u spare, %u bad blocks\n", MTDSWAP_PREFIX, part, swap_size / 1024, spare_cnt, bad_blocks); - d = kzalloc(sizeof(struct mtdswap_dev), GFP_KERNEL); + d = kzalloc(sizeof(*d), GFP_KERNEL); if (!d) return; - mbd_dev = kzalloc(sizeof(struct mtd_blktrans_dev), GFP_KERNEL); + mbd_dev = kzalloc(sizeof(*mbd_dev), GFP_KERNEL); if (!mbd_dev) { kfree(d); return; -- 2.12.2