From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31621E5B9B; Sat, 10 May 2025 07:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746861314; cv=none; b=Fk+mhLKTCwgy1E8KVcAU8SQWNdknZaR4iowFVr44YpsSMhNkWPRVGe7iyST+mLddpHSqJqfCS5u67TSrvqhL99X8u87bjTUNEydhBm57ZBOX5bf747Wi5ct3HQENxJan0xpImpA8tH/Z7nbklwmKucaixLhBM1EaiOfK9bvhXMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746861314; c=relaxed/simple; bh=BEOqE2tqMAxWaoMXbA9V5M7++Jbo2p1chC3Wvukt7Wo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=kFiIxwaHWJ+y2Witvi/wvEQqDhQh/Oi4vUkQE6QrC0qfK2eJWw+Kpfa6As+pBym05wGAkeWt4rQP+ED5YD3swE9Su5pfVEfdjrBRAKPouDK1LGoT/MCVj0O7jQTRmXr/GFQEHN/cbT4pVY0iISP3Rzhr9LBI61ecL1kSoKivPh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=QViP04k7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="QViP04k7" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54A6Tkrt018863; Sat, 10 May 2025 07:14:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UCgcrdULWipSXWVwkvOHsT5HbMWYQ29OYxYE22eVPDU=; b=QViP04k7jGdK7TIL q1Qf0hPgauZl87R5XPm9r+qeSDq7pnwv1kOdjauIrjvMxpBscYVUcqAKLCjbcj1K ucKuS+Ln6mnmTR5PXIcvBj0D8I8vVcrOMtRzCa8i6jbw13Sgsz3zm2ORn3NM9r1e AeUqC/ndobAHx/ykd6LXui2xtLUx7ksKWUFlp8Nvt9YniZWIzV7HgB3ZUzwCSIvu 0FOsO4AKMLM1IBhmNbjv3jYAP8gOiCHqpp3mOGrC0hXKs+BY6sVERzJBAp6s1yJl U6jkZ7bRbIkjp3EPaJfPiqvbEC2kvbSS5U4XJfB1LwQlcDLWDnsbP1QCNUzngmQ8 q58cwQ== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46hwt90asj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 10 May 2025 07:14:51 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 54A7EoRp020408 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 10 May 2025 07:14:50 GMT Received: from [10.204.73.14] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Sat, 10 May 2025 00:14:44 -0700 Message-ID: Date: Sat, 10 May 2025 12:44:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC/WIP v2 4/9] arm64: dts: qcom: sa8775p: Add support for camss To: Vikram Sharma , , , , , , , , , , , , , CC: , , , , References: <20250427070135.884623-1-quic_vikramsa@quicinc.com> <20250427070135.884623-5-quic_vikramsa@quicinc.com> Content-Language: en-US From: Suresh Vankadara In-Reply-To: <20250427070135.884623-5-quic_vikramsa@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTEwMDA3MCBTYWx0ZWRfX9SV3GmetpTwc X0VXYu1G47/tEnvP8FWh+hdMTNn0XGp1bPOdeZBTnzepG7hlfy7rS1XnTE7l+I3Zud/9DSX4n1n WGAIiI1mvlAC5njItQgjfzkmKqdxb3iOhqhJ/sMqLuqFbz5MlA6ffYESnF0yaqojtJAD5ZgtfOp Y0S1lmHYpWgCknzpCAMtZkJn44CAlBiLcsbVGRoYNFp2lbVn2Uk/ZbDLSVDTnYj9tdT2to6Vkpd s16ZMg+2Dk3DwfJUPMj7fY6YOCwBPOrT2ec9BYgG5egwaties5K4S3x7PWPoCyGATPv6whz54EH ozZhSlHCR4atayqVQZtEE6DVEbKKpqq+DHcIA6uccj/nbV4udHFUe4zBKK401rA05pgDL8O/bTc PBb7LntAykdVa9XFAxNa+YRNqiTlafy4IVsfJjQWIA9Zrmu+e5O9hd5PdT5q6JG0OkFaU+7m X-Proofpoint-ORIG-GUID: Kxw6DUOrPUofECTmBkYuMgyl2MM_WRwy X-Proofpoint-GUID: Kxw6DUOrPUofECTmBkYuMgyl2MM_WRwy X-Authority-Analysis: v=2.4 cv=a58w9VSF c=1 sm=1 tr=0 ts=681efceb cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=OqTgW8rPjYiluJQXZTQA:9 a=QEXdDO2ut3YA:10 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-10_03,2025-05-09_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 clxscore=1011 impostorscore=0 mlxscore=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505100070 On 4/27/2025 12:31 PM, Vikram Sharma wrote: > Add changes to support the camera subsystem on the SA8775P. > > Co-developed-by: Suresh Vankadara > Signed-off-by: Suresh Vankadara > Signed-off-by: Vikram Sharma > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 187 ++++++++++++++++++++++++++ > 1 file changed, 187 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 5bd0c03476b1..81eadb2bb663 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -3940,6 +3941,192 @@ videocc: clock-controller@abf0000 { > #power-domain-cells = <1>; > }; > > + camss: isp@ac7a000 { > + compatible = "qcom,sa8775p-camss"; If more number of nodes are added for CAMSS, adding isp in compatible string helps to differentiate. > + reg-names = "csid0", > + "csid1", > + "csid_lite0", > + "csid_lite1", > + "csid_lite2", > + "csid_lite3", > + "csid_lite4", > + "csid_wrapper", csid wrapper is top register set, which is applicable for both csid 0 and csid 1. It is logical to keep along with csid0 and csid1, instead of alpha numerical order. > + > + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, > + <&camcc CAM_CC_CORE_AHB_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>, > + <&camcc CAM_CC_CPAS_FAST_AHB_CLK>, > + <&camcc CAM_CC_CPAS_IFE_LITE_CLK>, > + <&camcc CAM_CC_CPAS_IFE_0_CLK>, > + <&camcc CAM_CC_CPAS_IFE_1_CLK>, > + <&camcc CAM_CC_CSID_CLK>, > + <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY1_CLK>, > + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY3_CLK>, > + <&camcc CAM_CC_CSI3PHYTIMER_CLK>, > + <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>, > + <&gcc GCC_CAMERA_HF_AXI_CLK>, > + <&gcc GCC_CAMERA_SF_AXI_CLK>, > + <&camcc CAM_CC_ICP_AHB_CLK>, > + <&camcc CAM_CC_IFE_0_CLK>, > + <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>, > + <&camcc CAM_CC_IFE_1_CLK>, > + <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>, > + <&camcc CAM_CC_IFE_LITE_CLK>, > + <&camcc CAM_CC_IFE_LITE_AHB_CLK>, > + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_LITE_CSID_CLK>; > + clock-names = "camnoc_axi", > + "core_ahb", > + "cpas_ahb", > + "cpas_fast_ahb_clk", > + "cpas_ife_lite", > + "cpas_vfe0", > + "cpas_vfe1", Maintain consistency on vfe/ife in complete camss node. In reg section, vfe is used for full and lite version. in clock-names section ife lite and vfe are used. As clock IDs upstream and ife is used for full and lite, this convention will be followed in camss node as well. > + "csid", > + "csiphy0", > + "csiphy0_timer", > + "csiphy1", > + "csiphy1_timer", > + "csiphy2", > + "csiphy2_timer", > + "csiphy3", > + "csiphy3_timer", > + "csiphy_rx", > + "gcc_axi_hf", > + "gcc_axi_sf", > + "icp_ahb", sf and icp_ahb clocks needed? > + > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, > + <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > + <&mmss_noc MASTER_CAMNOC_SF QCOM_ICC_TAG_ACTIVE_ONLY > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "ahb", > + "hf_0", > + "sf_0"; sf_0 needed? > + > + iommus = <&apps_smmu 0x3400 0x20>; Regards, Suresh Vankadara.