From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 929102FDC4B for ; Thu, 4 Dec 2025 08:54:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764838444; cv=none; b=oewKLxoPwPVY2sSuzuv4y6b+QF4Ck2YSiT6YEjWObaJInKMQ6+8w7cU2Z0us/Jj78WH3VgVnqcj51FmXN4Xl7nwc7ZqkSR6FvqEg3oY0GQxpX+UMo8LJNSSbAZWIuDij2sIPpUNKjo5RFX1gtZ2QCyUmfN9itUHzhbkylek3/AI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764838444; c=relaxed/simple; bh=Hnh7HF3toQOUTtMRZEW6IdEM1+kyGkkQr9xHVruOSFA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TKpEhvQWOqaqz/c+N5pXp6w0zyx6FLjFF9FiQooLZ54oz3kZbgpm7/9Xqq51E9UjTHV8Jmd8AMMYc+yKgzLEl74YZx4NpMWtbTfvvM3aNtUIb7oYr0bRnIe3bODMvyL+M4tEjgATurWyWKaQOy44a/ZjKzs2y4H0XsvCft1r+aw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XxvWxeW4; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DL441gLZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XxvWxeW4"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DL441gLZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764838440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m+RROGbd82iRnOs3Nzwo2Z6WPhdY3ptA/NeS0/WSLQA=; b=XxvWxeW4BSKUJCoo3Yjx95WAQX+tSzSRuv5CzeUUK5IvgJApPq6IWM8/kgYoNT/zIwPxW0 8tNrm8ofPJX6wprZ5N+nSWNdOkD6nBBvrl/XIEp5WvgXqYzttufc9cWVG1qesvLGwgcb3g pQGVkzHj+MZl0galcSYapBAAKThwO5s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-LLqLy07sMtW8E8cCGcRbqw-1; Thu, 04 Dec 2025 03:53:58 -0500 X-MC-Unique: LLqLy07sMtW8E8cCGcRbqw-1 X-Mimecast-MFC-AGG-ID: LLqLy07sMtW8E8cCGcRbqw_1764838438 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4779d8fd4ecso2819235e9.1 for ; Thu, 04 Dec 2025 00:53:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764838437; x=1765443237; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m+RROGbd82iRnOs3Nzwo2Z6WPhdY3ptA/NeS0/WSLQA=; b=DL441gLZDQ4615YkpUgiWgxHfcvhaTe7oCOeLld7/j1NqS9FJPWWl6mfoZyBCYmlZk yKlqWEKJRRCie2QqZkDzhPpUAJDSxlxSq2g1Prvlgs3/F8mrsJ/v7/qr0mQJxo9K4ekR HsC5y7+y2ihjAkuBvsaR3TmPanYBBjlfNa55dXNj6xjopj3ABSCt+XMd+xSm2ARTRHsf 3uoMQ/nrU5r08o3e0njyxuGLOqQY3VhVZ6+iW14F3pSkUHfQNT69rgqZQq1rYBT4jZ5z 7dK4eQ4GW68NK1nXzFCPzPajc3MHg/AqOh/jNT1OcVvYBG7iuo38u8IGDTG0RsUFueMR 87AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764838437; x=1765443237; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m+RROGbd82iRnOs3Nzwo2Z6WPhdY3ptA/NeS0/WSLQA=; b=J/j5bHDcTJXg718hPs9ykpIUOqhVNx8yz9Q6afvzzYkO4I9gv/23zh5xIKTcXPssD3 P06c3lMrvkNcH+4U7s01sEBK7OtZ/kRXkC2PPBPlYxsPoySQVx7i9A+4mwI07TBj52v9 9bWgnhIq2j3ns1qLuqUtQTqSntpCoU8aH34K5B8fKttl7/jc5dbqROZRi8iYp+ubSdiY Xb3IeI3l/0Vg5hfUNF78/vnY/w7MDVqP2NhK+HolGJqmpfr0D357eSvHCYhs1fWEYEZg U268Dk2X8bBff8zX9kBzEplWyyZhsesA63fvWrMeF8oB/meBpYfoFJzWs0UOh3jeCHCI qJow== X-Forwarded-Encrypted: i=1; AJvYcCVaSzwpj57zIKa04+23/zNPwPCClg0UMg04Uokt8T3ujFMpMtaNk38C19LgdrtEkM/m/8t9vuV/ev/+wEs=@vger.kernel.org X-Gm-Message-State: AOJu0YyMiBFeTjhdykDj1U0BdcK2PCPfwwnF2MSkYUZ+0vbuEnDgzTNJ 5RFO7Get2x3BopVZE1g3luDKRzLmfu9gaHPERTWO7UUWins3l25riMn/OoUfVh8MXxJiEUXfbF0 8z8k9tkYPpw6QXwG1B0CRlpCS4hWDhcndisQpDmiT8mS4OlQ+opp7LgVyccvZ4PC/6A== X-Gm-Gg: ASbGnctRplIxeciF646e9JBy8qQpEntzg0KtnCfhGSXyZnUGG9K/hPlo2REkcUaNsgU YzocgqYTmiMwzERSXxjg/AU2tRdZaEHIGVD8WwWas0cLtkk2aiRdo/pqHwN67b3ZPdMuBT8gAR9 DSM+XuaTx7c2daE/Dmd4RQz0CgepQgvRqO0tdNUL3QqozZBQKOKFBqX3qNWm1aMCqshzMKyD2ju hDuXYt4yvap1dGJk++Xp7Uq/jiRVkQqaU9r1tDKmPknUzGsP9OVinuj45Mz5p0R03GST+Ten29/ 3n82GIsHzLho4s+B9ZlHmReqOwxfoUynDgwGuV86ro8yjPj5ETa1E55tiQ4Gxf7HxTHRZaa2Dtb jHbXAEpvBbPdJ X-Received: by 2002:a05:600c:3151:b0:479:255f:8805 with SMTP id 5b1f17b1804b1-4792eb10e97mr24490145e9.4.1764838437602; Thu, 04 Dec 2025 00:53:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHdoOoX89LYoqg9vGC/S46dUkmd/JqxNYom3WUE3CEBjnMhlYwrZPQ9lVJw/8DiVw0VpIa8aA== X-Received: by 2002:a05:600c:3151:b0:479:255f:8805 with SMTP id 5b1f17b1804b1-4792eb10e97mr24489965e9.4.1764838437222; Thu, 04 Dec 2025 00:53:57 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.24]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4793093a9dcsm23134795e9.7.2025.12.04.00.53.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 00:53:56 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 09:53:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: fec: ERR007885 Workaround for XDP TX path To: Wei Fang , shenwei.wang@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org Cc: imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251128025915.2486943-1-wei.fang@nxp.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251128025915.2486943-1-wei.fang@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/28/25 3:59 AM, Wei Fang wrote: > The ERR007885 will lead to a TDAR race condition for mutliQ when the > driver sets TDAR and the UDMA clears TDAR simultaneously or in a small > window (2-4 cycles). And it will cause the udma_tx and udma_tx_arbiter > state machines to hang. Therefore, the commit 53bb20d1faba ("net: fec: > add variable reg_desc_active to speed things up") and the commit > a179aad12bad ("net: fec: ERR007885 Workaround for conventional TX") have > added the workaround to fix the potential issue for the conventional TX > path. Similarly, the XDP TX path should also have the potential hang > issue, so add the workaround for XDP TX path. > > Fixes: 6d6b39f180b8 ("net: fec: add initial XDP support") > Signed-off-by: Wei Fang > --- > drivers/net/ethernet/freescale/fec_main.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c > index 3222359ac15b..e2b75d1970ae 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -3948,7 +3948,12 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep, > txq->bd.cur = bdp; > > /* Trigger transmission start */ > - writel(0, txq->bd.reg_desc_active); > + if (!(fep->quirks & FEC_QUIRK_ERR007885) || > + !readl(txq->bd.reg_desc_active) || > + !readl(txq->bd.reg_desc_active) || > + !readl(txq->bd.reg_desc_active) || > + !readl(txq->bd.reg_desc_active)) > + writel(0, txq->bd.reg_desc_active); > > return 0; > } LGTM! Side note for a net-next follow-up: please consider moving this logic in a reusable helper, since you already have a few potentials call sites. /P