From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6419413E03E for ; Tue, 19 Nov 2024 21:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732052451; cv=none; b=SVtjTxUB32QqF1v9EFhfFJn4MnkDCyuHQ+ZnPtnqdvG6tMdwuMwAqDxq06G4trdJ1X4Dg2AfUY3fiPTxsZR1WdbcxviCHQMnSNaHvffg8XBXWLef+hym3r17/dnqqRre5DVz/Y80GC6Z1z4OGyu5ijFmudh/Z2+ThcV29IXL2bI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732052451; c=relaxed/simple; bh=HE3n513xHhZThcE6jVMoZF6XwhCQEWW5VGxysIXxWto=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aBykJUDc/Re5d6smfDZiz1abFKo03Ux8XvAzO7bsOQqJmun3wPMIxiH1A11cVA9kBNcOfjDM+H5pk8aHBuu8ReHd6xEoPktZt+v6LNyzAq4ZNJIa6deVJfo0bjq0Shy89eGZWWblAI/9GxYZ4nWIDm/6DosOsBU7mYZQdHguFmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=K1qSdKMS; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="K1qSdKMS" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3823f1ed492so116183f8f.1 for ; Tue, 19 Nov 2024 13:40:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732052448; x=1732657248; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lkxeQUfNljLvLRiRZhalC+n4lyNit8qK2o0nRa/RK2k=; b=K1qSdKMSFk3EJ+/mZ8UxMxt7TvsHiFvKVN5P+h1MNR2YD8wt8k0pcRSXQv/dfx57Km Au7ku0/giiqrvxDnldqLQvSpKT7TCcyMnLMPXr8BwAq4Vt+btFg5Kv7ebShQNgaGb1My 7XaJgv3xAQLKAFi9/TzP6aUSALygr5ka8lByTcOV0qURAQ90gVu8aOG6x72tNWrOnrEz 3/CBq6TvDLjd2E42V8eyxqDwaOYEPg8i3GKUg/PfdH8OXY60EpKU7Om1KviLT1DA342B xFpRzdkzvC1yPZYXtOjdZNegamh8rEUfzvEpE7qZiPBfAdu6ckYHi0rOJv4O0QGWLHpx iPpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732052448; x=1732657248; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lkxeQUfNljLvLRiRZhalC+n4lyNit8qK2o0nRa/RK2k=; b=wtPigTbFy9bCZ67H0nK0JFV/zeqqqWZRgF/KtfsqqC7aEH28FUKFtbb3A4DVuMSE/2 OLU6h+sxfpAuQve23OPaXbsiQNOiRUPFbGfB1tUXHsN5jWkmyxt8YILToLM3B/JPqApb WCmW1xoJeYnuN070UoEBoi5hkRKZw39r3MZ3YjI34gds64r1A3jIFx1Z4XBRIg+csD+g KnKBZThshTocugGS/SBjbV96MbqJndl6Mg21Sf5Ikz3uOz2lgzq9DHKBjt3eotzBbJwZ UJRydUKMAgYDNoCNnpiMoY4kPV5AmXI8TleJLUc4IUh9yEeHGs1qaEx0mErN3rif2+3d YC9g== X-Forwarded-Encrypted: i=1; AJvYcCU9spi25OFNtL33cujVZquFInf6d6wpzYIHOXseJleFmE1CDgzkh2zITufrAogbgHQPdLhx0napagmnR0c=@vger.kernel.org X-Gm-Message-State: AOJu0YxfgCUD3R8IFH8V/dCTHA1eRlqDVJd7rM9vmn/cjAiVKqvng4L5 zdklTTyeey7rlERtOXBHwZ34fjP89lb1gkVDwCD9lHOaNrLaCt82wF5pFWqJ6M8= X-Google-Smtp-Source: AGHT+IG6bv5/VShXyjrdqEjy+T/UO+kLOX7JIB5cP3VCGPfmzISuivqKLJjNxAIIX4ocGdqh24oTtw== X-Received: by 2002:a5d:5f91:0:b0:37d:47eb:b586 with SMTP id ffacd0b85a97d-3824cb30e45mr4340383f8f.4.1732052447252; Tue, 19 Nov 2024 13:40:47 -0800 (PST) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-382549055f2sm366236f8f.16.2024.11.19.13.40.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2024 13:40:46 -0800 (PST) Message-ID: Date: Tue, 19 Nov 2024 22:40:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14] thermal/drivers/mediatek/auxadc_thermal: expose all thermal sensors To: Hsin-Te Yuan Cc: "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , Matthias Brugger , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, James Lo , Michael Kao , Hsin-Yi Wang , Ben Tseng References: <20241025-auxadc_thermal-v14-1-96ab5b60c02e@chromium.org> <5dd2d2a3-6eff-45fb-8af8-593945235dd3@linaro.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 19/11/2024 08:38, Hsin-Te Yuan wrote: > On Fri, Nov 15, 2024 at 12:48 AM Daniel Lezcano > wrote: >> >> >> Hi, >> >> On 25/10/2024 14:05, Hsin-Te Yuan wrote: >>> From: James Lo >>> >>> Previously, the driver only supported reading the temperature from all >>> sensors and returning the maximum value. This update adds another >>> get_temp ops to support reading the temperature from each sensor >>> separately. >>> >>> Especially, some thermal zones registered by this patch are needed by >>> MT8183 since those thermal zones are necessary for mtk-svs driver. >> >> The DT for the mt8183 describes the sensor id = 0 as the CPU. On this, >> there is a cooling device with trip points. >> >> The driver registers the id=0 as an aggregator for the sensors which >> overloads the CPU thermal zone above. >> >> Why do you need to aggregate all the sensors to retrieve the max value ? >> >> They are all contributing differently to the heat and they should be >> tied with their proper cooling device. >> >> I don't think the thermal configuration is correct and I suggest to fix >> this aggregator by removing it. >> >> >> > As far as I know the thermal design of Mediatek's board is based on > the highest temperature of the whole board. Also, removing the > aggregator will break all the boards using this driver. AFAICT, it is not a thermal design but a thermal configuration. What is the rational of using power numbers related to the CPU but aggregate all temperatures as an input to the governor ? And for example, the mt8173 has 4 banks and 4 sensors per banks, so 16 sensors. And they are all grouped together under the thermal zone "cpu-thermal" with the cpu cooling device. So if the GPU is getting hot, we cool down the CPU ? > By the way, I heard that baylibre is working on multi-sensor > aggregation support, which can be the alternative solution for the > aggregator in this driver, but that should be another story and is > unrelated to this patch. Right. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog