From: "Matias Bjørling" <mb@lightnvm.io>
To: javier@cnexlabs.com
Cc: javier@javigon.com, hans.holmberg@cnexlabs.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: lightnvm: pblk: avoid ref warning on cache creation
Date: Fri, 23 Nov 2018 09:23:56 +0100 [thread overview]
Message-ID: <cfcc4dee-c07f-156f-4523-1bda9c878b02@lightnvm.io> (raw)
In-Reply-To: <2D1F9096-EFF8-43C2-8403-9897B3D36409@cnexlabs.com>
On 11/23/2018 09:16 AM, Javier Gonzalez wrote:
>
>
>> On 23 Nov 2018, at 09.14, Matias Bjørling <mb@lightnvm.io> wrote:
>>
>>> On 11/22/2018 02:46 PM, Javier González wrote:
>>> Matias,
>>> Can you pick this up for 4.20? Even though it is not an error per se, it
>>> does trigger an ugly false positive warning when CONFIG_REFCOUNT_FULL is
>>> set.
>>> Thanks,
>>> Javier
>>> Javier González (1):
>>> lightnvm: pblk: avoid ref warning on cache creation
>>> drivers/lightnvm/pblk-init.c | 14 +++++---------
>>> 1 file changed, 5 insertions(+), 9 deletions(-)
>>
>> It is too late to get it for 4.20. I'll pull it in for 4.21.
>
> Well, if it is a fix it’s not too late AFAIK. It also applies to a patch picked up in this series. We should have catches this before.
>
> But I guess it’s your call.
There is a likelihood that Linus would catch it, with the result of fire
& fury. I don't feel like using one of my cat life's for this one.
>
>>
>> We can put on a Fixes: 1864de94ec9d6 "lightnvm: pblk: stop recreating global caches" if you want Greg and friends to pick picked it up for stable kernels?
>
> I didn’t add it as it is not a bug in itself. But it is good to add it. Can you do it.
>
I'll do it.
> Javier.
>
next prev parent reply other threads:[~2018-11-23 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 13:46 Javier González
2018-11-22 13:46 ` [PATCH] " Javier González
2018-11-23 10:04 ` Hans Holmberg
2018-11-30 8:36 ` Matias Bjørling
2018-11-23 8:14 ` Matias Bjørling
2018-11-23 8:16 ` Javier Gonzalez
2018-11-23 8:23 ` Matias Bjørling [this message]
2018-11-23 8:31 ` Javier Gonzalez
2018-11-23 8:41 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfcc4dee-c07f-156f-4523-1bda9c878b02@lightnvm.io \
--to=mb@lightnvm.io \
--cc=hans.holmberg@cnexlabs.com \
--cc=javier@cnexlabs.com \
--cc=javier@javigon.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®