From: Markuss Broks <markuss.broks@gmail.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: sm5703: Fix missing n_voltages for fixed regulators
Date: Sun, 9 Apr 2023 16:25:02 +0300 [thread overview]
Message-ID: <cfcd6736-f822-fdda-a84d-4f4bb91cd653@gmail.com> (raw)
In-Reply-To: <20230409025529.241699-1-axel.lin@ingics.com>
Looks good.
Reviewed-by: Markuss Broks <markuss.broks@gmail.com>
On 4/9/23 05:55, Axel Lin wrote:
> Set n_voltages = 1 for fixed regulators.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/sm5703-regulator.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/regulator/sm5703-regulator.c b/drivers/regulator/sm5703-regulator.c
> index 38e66df378a5..702461cf075e 100644
> --- a/drivers/regulator/sm5703-regulator.c
> +++ b/drivers/regulator/sm5703-regulator.c
> @@ -42,6 +42,7 @@ static const int sm5703_buck_voltagemap[] = {
> .type = REGULATOR_VOLTAGE, \
> .id = SM5703_USBLDO ## _id, \
> .ops = &sm5703_regulator_ops_fixed, \
> + .n_voltages = 1, \
> .fixed_uV = SM5703_USBLDO_MICROVOLT, \
> .enable_reg = SM5703_REG_USBLDO12, \
> .enable_mask = SM5703_REG_EN_USBLDO ##_id, \
> @@ -56,6 +57,7 @@ static const int sm5703_buck_voltagemap[] = {
> .type = REGULATOR_VOLTAGE, \
> .id = SM5703_VBUS, \
> .ops = &sm5703_regulator_ops_fixed, \
> + .n_voltages = 1, \
> .fixed_uV = SM5703_VBUS_MICROVOLT, \
> .enable_reg = SM5703_REG_CNTL, \
> .enable_mask = SM5703_OPERATION_MODE_MASK, \
next prev parent reply other threads:[~2023-04-09 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 2:55 Axel Lin
2023-04-09 13:25 ` Markuss Broks [this message]
2023-04-11 13:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfcd6736-f822-fdda-a84d-4f4bb91cd653@gmail.com \
--to=markuss.broks@gmail.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®