From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF58C4363D for ; Wed, 7 Oct 2020 13:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D9DC208C7 for ; Wed, 7 Oct 2020 13:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728480AbgJGNfL (ORCPT ); Wed, 7 Oct 2020 09:35:11 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:51246 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728177AbgJGNfJ (ORCPT ); Wed, 7 Oct 2020 09:35:09 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kQ9b2-0002RT-1J; Wed, 07 Oct 2020 13:35:08 +0000 Subject: Re: tracing: Add support for dynamic strings to synthetic events To: Steven Rostedt Cc: Tom Zanussi , Ingo Molnar , "linux-kernel@vger.kernel.org" References: <20201007093036.423a1b72@gandalf.local.home> From: Colin Ian King Message-ID: Date: Wed, 7 Oct 2020 14:35:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201007093036.423a1b72@gandalf.local.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/10/2020 14:30, Steven Rostedt wrote: > On Wed, 7 Oct 2020 14:08:38 +0100 > Colin Ian King wrote: > >> Hi, >> >> Static analysis with Coverity has detected a duplicated condition in an >> if statement in the following commit in source >> kernel/trace/trace_events_synth.c >> >> commit bd82631d7ccdc894af2738e47abcba2cb6e7dea9 >> Author: Tom Zanussi >> Date: Sun Oct 4 17:14:06 2020 -0500 >> >> tracing: Add support for dynamic strings to synthetic events >> >> Analysis is as follows: >> >> 493 for (i = 0; i < event->n_fields; i++) { >> >> Same on both sides (CONSTANT_EXPRESSION_RESULT) >> pointless_expression: The expression event->fields[i]->is_dynamic && >> event->fields[i]->is_dynamic does not accomplish anything because it >> evaluates to either of its identical operands, event->fields[i]->is_dynamic. >> >> Did you intend the operands to be different? >> >> 494 if (event->fields[i]->is_dynamic && >> 495 event->fields[i]->is_dynamic) > > Bah, I believe that was suppose to be: > > if (event->fields[i]->is_string && > event->fields[i]->is_dynamic) > > I'll go and fix that. Ah, makes sense. Thanks! > > -- Steve > >> 496 pos += snprintf(buf + pos, LEN_OR_ZERO, >> 497 ", __get_str(%s)", >> event->fields[i]->name); >> 498 else >> 499 pos += snprintf(buf + pos, LEN_OR_ZERO, >> 500 ", REC->%s", >> event->fields[i]->name); >> 501 } >> >> Colin >