From: "Michael Kerrisk" <mtk.manpages@googlemail.com>
To: "Davide Libenzi" <davidel@xmailserver.org>
Cc: "Matthew Helsley" <matthltc@us.ibm.com>,
"Ulrich Drepper" <drepper@redhat.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
mtk.manpages@gmail.com,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH 08/18] flag parameters: epoll_create
Date: Wed, 7 May 2008 01:10:53 +0200 [thread overview]
Message-ID: <cfd18e0f0805061610i48146b3fra3ac378643d51c9e@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805061540560.25162@alien.or.mcafeemobile.com>
On Wed, May 7, 2008 at 12:41 AM, Davide Libenzi <davidel@xmailserver.org> wrote:
>
> On Tue, 6 May 2008, Matthew Helsley wrote:
>
> >
> > On Sun, 2008-05-04 at 23:42 -0400, Ulrich Drepper wrote:
> > > This patch adds the new epoll_create2 syscall. It extends the old epoll_create
> > > syscall by one parameter which is meant to hold a flag value. In this
> > > patch the only flag support is EPOLL_CLOEXEC which causes the close-on-exec
> > > flag for the returned file descriptor to be set.
> >
> > Davide, Ulrich,
> >
> > A minor question: Why did you choose to pass the seemingly useless
> > "size" parameter into the new epoll_create2 system call? I did some
> > googling for previous threads with this series and couldn't find a
> > discussion on why you chose to keep it.
>
> The very first implementations were using an hash, and that was a size
> hint.
So, why not simply remove this argument in the new API, since it is now useless?
next prev parent reply other threads:[~2008-05-06 23:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 3:42 Ulrich Drepper
2008-05-05 4:52 ` Davide Libenzi
2008-05-06 21:06 ` Matthew Helsley
2008-05-06 22:41 ` Davide Libenzi
2008-05-06 23:10 ` Michael Kerrisk [this message]
2008-05-06 23:20 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd18e0f0805061610i48146b3fra3ac378643d51c9e@mail.gmail.com \
--to=mtk.manpages@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=mtk.manpages@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®