mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Kerrisk <mtk.manpages@googlemail.com>
To: Greg KH <greg@kroah.com>
Cc: Robert Hancock <hancockr@shaw.ca>,
	Greg KH <public-greg-U8xfFu+wG4EAvxtiuMwx3w@hugh.gmane.org>,
	public-mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@hugh.gmane.org,
	public-linux-man-u79uwXL29TY76Z2rM5mHXA@hugh.gmane.org,
	public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@hugh.gmane.org
Subject: Re: open(2) says O_DIRECT works on 512 byte boundries?
Date: Thu, 29 Jan 2009 15:59:12 +1300	[thread overview]
Message-ID: <cfd18e0f0901281859u250f202fj3ef40fb8531f1dc3@mail.gmail.com> (raw)
In-Reply-To: <20090129011758.GA26534@kroah.com>




On Thu, Jan 29, 2009 at 2:17 PM, Greg KH <greg@kroah.com> wrote:
>
>
>
> On Wed, Jan 28, 2009 at 06:41:49PM -0600, Robert Hancock wrote:
>>
>>
>> Greg KH wrote:
>>> In looking at open(2), it says that O_DIRECT works on 512 byte boundries
>>> with the 2.6 kernel release:
>>>      Under Linux 2.4, transfer sizes, and the alignment of the user
>>>      buffer and  the file offset must all be multiples of the logical
>>>      block size of the file system.  Under Linux 2.6, alignment  to
>>>      512-byte  boundaries suffices.
>>> However if you try to access an O_DIRECT opened file with a buffer that
>>> is PAGE_SIZE aligned + 512 bytes, it fails in a bad way (wrong data is
>>> read.)
>>> Is this just a mistake in the documentation?  Or am I reading it
>>> incorrectly?
>>> I have a test program that shows this if anyone wants it.
>>
>> Well, it sounds like a bug to me.. even if it's not supported, if you do
>> such an access, surely the kernel should detect that and return EINVAL or
>> something rather than reading corrupted data..
>
> It doesn't.  It says the read is successful, yet the data is not really
> read into the buffer.  Portions of it is, but not the amount we asked
> for.

Greg,

Can you post your test program?

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
git://git.kernel.org/pub/scm/docs/man-pages/man-pages.git
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html



  parent reply	other threads:[~2009-01-29  4:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 21:33 Greg KH
2009-01-29  0:41 ` Robert Hancock
     [not found]   ` <20090129011758.GA26534@kroah.com>
2009-01-29  2:59     ` Michael Kerrisk [this message]
2009-01-29  3:13       ` Greg KH
2009-01-29 15:40         ` Jeff Moyer
2009-01-30  6:16           ` Greg KH
2009-01-29  5:13 ` KAMEZAWA Hiroyuki
2009-01-29  7:10   ` KOSAKI Motohiro
2009-01-30  6:17     ` Greg KH
2009-02-02 22:08       ` Andrea Arcangeli
2009-02-03  1:29         ` KAMEZAWA Hiroyuki
2009-02-03  2:31           ` Andrea Arcangeli
2009-02-03  2:55             ` KAMEZAWA Hiroyuki
2009-02-03  3:42               ` KAMEZAWA Hiroyuki
2009-02-06 17:55               ` Andrea Arcangeli
2009-02-03  3:50         ` Greg KH
2009-02-03 15:01           ` Andrea Arcangeli
2009-02-03  4:13         ` KAMEZAWA Hiroyuki
2009-02-03  4:38         ` KAMEZAWA Hiroyuki
2009-02-03 15:08           ` Andrea Arcangeli
2009-02-04 23:41         ` Greg KH
2009-02-06 17:54           ` Andrea Arcangeli
2009-02-06 18:38             ` Andrea Arcangeli
2009-02-07 13:32             ` Izik Eidus
2009-02-07 15:33               ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfd18e0f0901281859u250f202fj3ef40fb8531f1dc3@mail.gmail.com \
    --to=mtk.manpages@googlemail.com \
    --cc=greg@kroah.com \
    --cc=hancockr@shaw.ca \
    --cc=mtk.manpages@gmail.com \
    --cc=public-greg-U8xfFu+wG4EAvxtiuMwx3w@hugh.gmane.org \
    --cc=public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@hugh.gmane.org \
    --cc=public-linux-man-u79uwXL29TY76Z2rM5mHXA@hugh.gmane.org \
    --cc=public-mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@hugh.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®