From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEC1E3A9854 for ; Tue, 28 Jul 2026 12:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785243136; cv=none; b=jDFrOqFwvGJdplLbJnL8yg0bA+0/aHe7MswIj4L7C22ZbHN9w6P78d9UKg1eHpcT4LTbTyJmUPt6gXFbeOzgmzDk8IzQXI2cp689fyvgasuzqJgzIIM+zzW3eXiCelkFvMkXEpkKCtOEgWwYDFZy7vKVAslon1/h7rzzP7e1kfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785243136; c=relaxed/simple; bh=FMdMDb1hsRT2zerT6pupP/XGqPrIeGTpfhSoF7SeLBw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HSULy888tVwokUSFk+e7BZI0H+2MW990nhWzKyj7bi3KA1ty3qQQ0Ir6WVVAYtAv7YZ83TbcEP1u2eWzb/yMI9TVPWiNmXFoposCz5gltjkCEDG6pszTaT5d+diol2v4XNG8xjc9A4XeNWkW1X1hzsS43sDT2gpXSw0FjjEMpRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lVuEeVgv; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lVuEeVgv" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-c15f020a223so513016966b.1 for ; Tue, 28 Jul 2026 05:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1785243133; x=1785847933; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6CEzrLHR91J0dNl9cxgDm1rKeXDnUWpCXkb68sIs8ng=; b=lVuEeVgvaH6RZ8PTiEAncKufX/MFlrRTYav1+NEPLJwhc/TpTZKzuvPo5avKNuPA8r nA5PeMln1hGBBqiD994YNDE4d7i8AmIzKLlyzwPpjNvvmJA1tGy05T7KYQVs+4JOYZ6G L7S29FQdKfdtS8JK/nex1/ywtCMX+hkqdVVtNaf5HgFOwzB9EgDGdi5H0BH33WnXLZYD Fu/20JOyKV77I8Czubto2j5hlM+ifbhcJ3m0/7Dk4Qglvd1KeNnks7XnVCpkrk6XPQAS ZGiolDVKP7vNv4xsCr2q17oLlPS2v3UVihnLUIwHdOXQYSOVglVXwCq8V8jcTHbAvzYh pwZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785243133; x=1785847933; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6CEzrLHR91J0dNl9cxgDm1rKeXDnUWpCXkb68sIs8ng=; b=qcMQAaBvI6ZBr7ity71HL089NZm1/xoomSy0+n407wv9ZAVRDyu6aiLARPavH//LVU d03hFgS9edroey6YaY/VrWQvXxhq7TegzNaYYN8XuW1CeoYInL9im5kNq974B5+NFmGB mNDmJOsSKueK9bEV8cV72BviWOwcmKB5gdziCDA06qxmYGxOjHs74i6/Sy6UnvEg2z6Z FYDx9M9MFj32E68SASJnhvdYj9DM98XXUthV+W2/wgnRoymGm/Tlb2dPSPR5LzVretiV qpkq1nSdaffF10VPSkmgTjNOfXH8FkSvSW15s0/VeQ0JggqD6PiY8cnwyx7nkzvSewGc 8Nqw== X-Forwarded-Encrypted: i=1; AHgh+RpLLDlV0uUQyJcm5AoaqR1INkFkgK+oHs2+0xu6SgjSFjrV8pwzk4heV6YCIkFrGV1cETMIi1OSU30KsvI=@vger.kernel.org X-Gm-Message-State: AOJu0YxYQsourehxOu+q6isijJiftSU8T2pv5ANZPsa2CjEpeGjXX8hj 8ajqfp0JQQhrBawF+C74nqAsFTLiFUohW7U8xhbuveLPry16lgRsNQgr5bR8lieJAtMtFkOCUcJ YkvDIzh4= X-Gm-Gg: AR+sD10SAVe5FeYV9aZKSgQLpIWfc6daaREosXGzxy98VN/LnIJG1uwklxb4vxfPPVr 0c/6ymHR3BijFeJZK2v/Mhtto/bfMtA4+Wn5ordfghqlsBogyp6PQ27ZSn68MaLWvkD+1rIBElh 1k69PQLslsiJYoNGNDwGZNYtktfAyNJKKdkHpJIMx5yc7RwHzljDC6lf2SKlvIB/ZVE9LtqOKgO 88msdAVVS5rQ5l8/YOLRikG4C8NfIsbxD74QR4X1/6DGl6/Fiz0avoEKCTrQVsyYCRtoMAd3Z23 3Vq5RR5e3aQaCxLGP3r9glT7fCxQRPkAynDOSwFa1KJ3pwOBOIf2BGVSreEQ6oXn9JK/54GSlhN 52Of0j8i+w5UxgrZNtfSQOxry34yTBNwZZhHCzuqmTQD7q7u+XhNKOpCE91EhbmzZbhrNGH5mGe 9DiNzEY0yydz+xGw== X-Received: by 2002:a17:906:6a18:b0:c1c:254c:16c1 with SMTP id a640c23a62f3a-c1f719f4dbemr120090466b.0.1785243133082; Tue, 28 Jul 2026 05:52:13 -0700 (PDT) Received: from [192.168.0.101] ([109.77.204.94]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c32f151fbsm773063966b.56.2026.07.28.05.52.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2026 05:52:12 -0700 (PDT) Message-ID: Date: Tue, 28 Jul 2026 13:52:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] media: qcom: iris: handle runtime PM resume failure in core deinit To: Hungyu Lin , vikash.garodia@oss.qualcomm.com Cc: dikshita.agarwal@oss.qualcomm.com, abhinav.kumar@linux.dev, mchehab@kernel.org, stefan.schmidt@linaro.org, hverkuil@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260604050451.41583-1-dennylin0707@gmail.com> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: <20260604050451.41583-1-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/06/2026 06:04, Hungyu Lin wrote: > Check the return value of pm_runtime_resume_and_get() in > iris_core_deinit(). > > If runtime PM resume fails, skip hardware power-off operations but > still perform software teardown and state transition. Also skip the > corresponding pm_runtime_put_sync() call to avoid unbalanced runtime > PM references. > > Fixes: bb8a95aa038e ("media: iris: implement power management") > Signed-off-by: Hungyu Lin > --- > Changes in v2: > - Keep software teardown and state transition when runtime PM resume fails > - Skip only hardware power-off operations and pm_runtime_put_sync() > > drivers/media/platform/qcom/iris/iris_core.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_core.c b/drivers/media/platform/qcom/iris/iris_core.c > index dbaac01eb15a..bf3c7f722490 100644 > --- a/drivers/media/platform/qcom/iris/iris_core.c > +++ b/drivers/media/platform/qcom/iris/iris_core.c Reviewed-by: Bryan O'Donoghue