Re: [PATCH v16 19/32] x86/resctrl: Find and enable usable telemetry events

[Reinette Chatre <reinette.chatre@intel.com>]

Hi Tony,

On 12/10/25 3:13 PM, Tony Luck wrote:
> Every event group has a private copy of the data of all telemetry event
> aggregators (aka "telemetry regions") tracking its feature type. Included
> may be regions that have the same feature type but tracking different guid
> from the event group's.
> 
> Traverse the event group's telemetry region data and mark all regions that
> are not usable by the event group as unusable by clearing those regions'
> MMIO addresses. A region is considered unusable if:
> 1) guid does not match the guid of the event group.
> 2) Package ID is invalid.
> 3) The enumerated size of the MMIO region does not match the expected
>    value from the XML description file.
> 
> Hereafter any telemetry region with an MMIO address is considered valid for
> the event group it is associated with.
> 
> Enable all the event group's events as long as there is at least one usable
> region from where data for its events can be read. Enabling of events
> can fail. Each event group is independent of other event groups. So even
> if no events can be enabled from one event group, keep running to enable
> other event groups.

Above describes how event groups are independent while I see the question needing
to be answered here as "Why enable an event group if one or more of its events
cannot be enabled?"

How about something like:
	Enabling of an event can fail if the same event has already been enabled as    
	part of another event group. It should never happen that the same event is      
	described by different guid supported by the same system so just WARN (via      
	resctrl_enable_mon_event()) and skip the event."   	

Can the "should" be replaced with a specific reason why this can never happen?

> 
> Note that it is architecturally possible that some telemetry events are
> only supported by a subset of the packages in the system. It is not expected
> that systems will ever do this. If they do the user will see event files in
> resctrl that always return "Unavailable".
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>

| Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette