From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B9C2C433F5 for ; Tue, 19 Apr 2022 13:58:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344053AbiDSOAw (ORCPT ); Tue, 19 Apr 2022 10:00:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235548AbiDSOAs (ORCPT ); Tue, 19 Apr 2022 10:00:48 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DB85938D88; Tue, 19 Apr 2022 06:58:05 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8170106F; Tue, 19 Apr 2022 06:58:05 -0700 (PDT) Received: from [10.32.36.25] (e121896.Emea.Arm.com [10.32.36.25]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C76403F766; Tue, 19 Apr 2022 06:58:02 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 14:58:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH V5 5/8] perf/tools: Add system error and not in transaction branch types Content-Language: en-US To: Anshuman Khandual , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, peterz@infradead.org, acme@kernel.org Cc: Robin Murphy , Suzuki Poulose , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org References: <20220404045046.634522-1-anshuman.khandual@arm.com> <20220404045046.634522-6-anshuman.khandual@arm.com> From: James Clark In-Reply-To: <20220404045046.634522-6-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2022 05:50, Anshuman Khandual wrote: > This updates the perf tool with generic branch type classification with two > new branch types i.e system error (PERF_BR_SERROR) and not in transaction > (PERF_BR_NO_TX) which got updated earlier in the kernel. This also updates > corresponding branch type strings in branch_type_name(). > > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Thomas Gleixner > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-perf-users@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Reviewed-by: James Clark > --- > tools/include/uapi/linux/perf_event.h | 2 ++ > tools/perf/util/branch.c | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h > index d37629dbad72..26d8f0b5ac0d 100644 > --- a/tools/include/uapi/linux/perf_event.h > +++ b/tools/include/uapi/linux/perf_event.h > @@ -253,6 +253,8 @@ enum { > PERF_BR_COND_RET = 10, /* conditional function return */ > PERF_BR_ERET = 11, /* exception return */ > PERF_BR_IRQ = 12, /* irq */ > + PERF_BR_SERROR = 13, /* system error */ > + PERF_BR_NO_TX = 14, /* not in transaction */ > PERF_BR_MAX, > }; > > diff --git a/tools/perf/util/branch.c b/tools/perf/util/branch.c > index a9a909db8cc7..abc673347bee 100644 > --- a/tools/perf/util/branch.c > +++ b/tools/perf/util/branch.c > @@ -51,7 +51,9 @@ const char *branch_type_name(int type) > "COND_CALL", > "COND_RET", > "ERET", > - "IRQ" > + "IRQ", > + "SERROR", > + "NO_TX" > }; > > if (type >= 0 && type < PERF_BR_MAX)