From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: Fix reversed nonblock flag
Date: Fri, 4 Oct 2019 11:32:02 +0300 [thread overview]
Message-ID: <cfd89ec4-f632-9274-6982-826bc9f45284@gmail.com> (raw)
In-Reply-To: <75be62996d115a3e2effa6753a6d803069131460.1570177340.git.asml.silence@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 940 bytes --]
I haven't followed the code path properly, but it looks strange to me.
Jens, could you take a look?
On 04/10/2019 11:25, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov <asml.silence@gmail.com>
>
> io_queue_link_head() accepts @force_nonblock flag, but io_ring_submit()
> passes something opposite.
>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> fs/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index c934f91c51e9..ffe66512ca07 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -2761,7 +2761,7 @@ static int io_ring_submit(struct io_ring_ctx *ctx, unsigned int to_submit,
>
> if (link)
> io_queue_link_head(ctx, link, &link->submit, shadow_req,
> - block_for_last);
> + force_nonblock);
> if (statep)
> io_submit_state_end(statep);
>
>
--
Yours sincerely,
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-10-04 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 8:25 Pavel Begunkov (Silence)
2019-10-04 8:32 ` Pavel Begunkov [this message]
2019-10-04 9:23 ` kbuild test robot
2019-10-04 9:33 ` kbuild test robot
2019-10-04 10:07 ` [PATCH v2] " Pavel Begunkov (Silence)
2019-10-04 13:05 ` Jens Axboe
2019-10-04 13:58 ` Pavel Begunkov
2019-10-04 14:01 ` [PATCH v3] " Pavel Begunkov (Silence)
2019-10-04 14:04 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd89ec4-f632-9274-6982-826bc9f45284@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®