Re: [PATCH v3] PCI: of: Drop error message on missing of_root node

[Hans Zhang <hans.zhang@cixtech.com>]

On 11/10/2025 6:54 PM, Andrea della Porta wrote:
> EXTERNAL EMAIL
> 
> When CONFIG_PCI_DYNAMIC_OF_NODES is enabled, an error message
> is generated if no 'of_root' node is defined.
> 
> On DT-based systems, this cannot happen as a root DT node is
> always present.
> On ACPI-based systems that declare an empty root DT node (e.g.
> x86 with CONFIG_OF_EARLY_FLATTREE=y), this also won't happen.
> On platforms where ACPI is mutually exclusive to DT (e.g. ARM)
> the error will be caught (and possibly shown) by drivers that
> rely on the root node.
> 
> Drop the error message altogether.
> 
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> ---
> Changes in V3:
> - Dropped the error message
> - Changed the commit subject
> 
> V2: https://lore.kernel.org/all/955bc7a9b78678fad4b705c428e8b45aeb0cbf3c.1762367117.git.andrea.porta@suse.com/
> ---
>   drivers/pci/of.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index 3579265f1198..71899b385f7c 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -775,7 +775,6 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
> 
>          /* Check if there is a DT root node to attach the created node */
>          if (!of_root) {
> -               pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
>                  return;
>          }
Hi,

Can {} also be deleted?

Best regards,
Hans

> 
> --
> 2.35.3
> 
>