From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E97652D6407 for ; Wed, 11 Feb 2026 10:01:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770804063; cv=none; b=ryxKPdE5x9uodx+qrcwXLgH8BexzDp+5kEbQmCH04XzhuPAlWS7dLgwS5P6MAr52k85d6M7qZEqEAjS0AEST3UjRNnASCn9w9vibhOEblDcor80nRgwM4ULBZ/r3T/Cz+xG2m34MrWExJUia2FOKJUFbY41OtlM/ZUKtaxbc3fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770804063; c=relaxed/simple; bh=mBbQ/PlNVLpbc4+TvvjBtK18WxXADozjYzh3fRdyLVI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=InYekUt0YxCcbd0x9sIlZx/7BWX+P0Lxi2cc33xlWSj5+naw3YozIzNNyKD+apEpricxGi2sqgiuzjJzDzwleqdpY7dO7iXipt71BWI7CQPTb6Uu+AzoRSv8j3c8QaBYqD9YU+iz/fIj8TQeb6ZQKdg7pB9sxWWwJeBPGoC03h8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PRcEd+a5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FeK7SrJN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PRcEd+a5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FeK7SrJN" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61B7qHuL3920970 for ; Wed, 11 Feb 2026 10:01:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Rv7cH++LnmwgZcqXk/m5EfA2rgQtFd7BW1CG8SndFUA=; b=PRcEd+a5PIrbXTYR FD6JG7cu61eCavnn7ly1stmpcWxhwyjHQgFKWG9R1zl+DYbgth6T+KcVkEe2iRfL 8XLCXhT1TVhTY8HuKs/Y9oLEa8a4gMXiM4+Wh2CEE0KMGu3SSJSviH3Wsrr4L1zH 0dN7SWgLNDe/MOZFLBorqgT6fJD3yCyHbodYngQCKvwqVsuW0ARyubODZEKo2kGj liUI8HTixBhSn9P8cu6PpsIoiygUtc7WgJqRRF7ulVUpvP3eUfZPob0P7oIUCY6Y 1A6WR7HYz2JG5A7vZs7qPmev4QdtQ7pLPDtEBmorORpijitmQqSLHSeXcVZbLlHe 4N02rg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c86akkewt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Feb 2026 10:01:00 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8ca3e7722f1so207510285a.1 for ; Wed, 11 Feb 2026 02:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770804060; x=1771408860; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rv7cH++LnmwgZcqXk/m5EfA2rgQtFd7BW1CG8SndFUA=; b=FeK7SrJN4sbq+KEy7WERcvwsSDayojz7rv9ZQeSBP9xwacAqCNMKGrPtWhfnWjUs48 bbVCIv4P2fvewtCDGRbAM/8V7eX8vG/YeLmvOvfKtwv06asqwRObx6jRHzRhEV93xQiA HZGJY763htWc6xE54nyZto3PXRt5vKA2RwRR7bmNbaCDNZPxB3CaAdL40t8Hq4ukKSln FTn5FUQn7wojXOM8kKs6uC37KWSnrRHECmS065Q48vnTNrJjPeeefcuuCYqzfdkq5Xji O7VTkrLYmkLoV6bDyBwZRyIigLoxaHMIQPAMcYFywXy/t97FKMGTybRAXl9DDH26UZSo hnFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770804060; x=1771408860; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rv7cH++LnmwgZcqXk/m5EfA2rgQtFd7BW1CG8SndFUA=; b=QpCafxKznYSPhonESmVwslTlNfj3PUzds0QROtHVnHThHKPY2EzMTvZB7qFJ7IkH5B 2aY5xBRm9006jjgrGQLQ5OTMa8z+5dTJQxpRZ6uY4tFY3K0DP4STR3237omjWJrXo9MU yZGx9v1X3K5UblQZrhebVGBDN9o4IkZmBKWwgiOcWhUs+6PcvbpxqSLZL4ogq5RwtKD0 hD0RmqQ7akjfrF4jbBqlYLVX/Mfie540q+2kAWFh64YyFG9s275upxsjzUDyZMvzcXOd 1hwwS1lEKxEb4iSOfyxtAK5895qmI0a0gKUq588Gjq19bPa/klUNWBw6UjshAdpXOvGO ZsqQ== X-Forwarded-Encrypted: i=1; AJvYcCVs3lqEeC2uO2r4C8orSPx6nVtEsbtkBX6xarEkBdb1vn7K50KmLl/3x3xcsCMOYFrPlsxGrxTslaZFFWA=@vger.kernel.org X-Gm-Message-State: AOJu0YzmfUAKDNUVsMipGfZOIP/z3EdNH5mJZnqEO8G/lvkegxgh2PQ8 HGenKlu/anrkIvKbMD9FWdEXIJN3DSRi2V2iTjMcxd/+m4ppjT7261Kie40mwo+MuCGVu67t05G r6HYcjCRiI3xanhpeoPOH7dPjmrIIGH8t5COobupSwhQUE7Aqi3wEZ3WMpMff4UzvWTk= X-Gm-Gg: AZuq6aIMY3Xfoo87zmRzcjWiqL6fYWqs+kmcvYaPMKBCMUmDSRePqdVQHC0Tgna63D1 zdjtulQTA1JK8uDxckxtwjtAYJLte8njI+EJSTaAjhh6PVA+3BEuInCHGU/a3wERoIvU/lC0eJR DK5W00i4AisnH2E83/sJZ0D72D24HptO5M6epBZ27VOBsqf9xKKcYAb8pVEy8j1sUebgdYxa4m8 CokoTVVQNBRz12BS41x0HnoYcDgZmlhpG7AEGZOtpW7tS7XBRKVMuk4pLYOSdnCC6woyO+AamGT 9JKhe0MGuSd3HSiUW7Or5efKyjuxBVmKiY7+dMqUxWuAaxkBQsja69bLwsPJHxCJlMOwg4gg+Qd cZg3mU4O0i2n0cPmgeLgezO2mD9v/uCovWTjYhjv8uP8iDRLk X-Received: by 2002:a05:620a:1a08:b0:8ca:ffe3:32a4 with SMTP id af79cd13be357-8cb1edd9aa9mr623906985a.42.1770804059960; Wed, 11 Feb 2026 02:00:59 -0800 (PST) X-Received: by 2002:a05:620a:1a08:b0:8ca:ffe3:32a4 with SMTP id af79cd13be357-8cb1edd9aa9mr623903485a.42.1770804059412; Wed, 11 Feb 2026 02:00:59 -0800 (PST) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b8f7ff17a44sm9101366b.0.2026.02.11.02.00.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Feb 2026 02:00:58 -0800 (PST) Message-ID: Date: Wed, 11 Feb 2026 10:00:57 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec To: Krzysztof Kozlowski Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexey.klimov@linaro.org, r.mereu@arduino.cc References: <20260209142428.214428-1-srinivas.kandagatla@oss.qualcomm.com> <20260209142428.214428-2-srinivas.kandagatla@oss.qualcomm.com> <20260211-holistic-precise-gazelle-fea9be@quoll> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260211-holistic-precise-gazelle-fea9be@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=HI7O14tv c=1 sm=1 tr=0 ts=698c535c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=KKAkSRfTAAAA:8 a=mtHiFRkL_bO2e_9l49wA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: a0o7L1Rc8DfOzy4E0HG-qdcW6-O1GY8f X-Proofpoint-ORIG-GUID: a0o7L1Rc8DfOzy4E0HG-qdcW6-O1GY8f X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjExMDA4MSBTYWx0ZWRfX/9oUcsiJ+Eg3 N/PEgYex+oejOH5RYC3ZAZqVs0CAM9ppBT1WVMoav4hthplYQBOTLq49jJ38UJOXNJkwDWMo38m 3NT+gorLsu7ugloRmxBEqduVoVj+S6iIfbXZ8uf4YxAPx4cKqHj436Fm/6n+GrARcnMYLtTr+Y3 Ngb/ewSVxvPx7Y/1zDAU4evsk9cPSk9wwPJNFVlWrj4UUNFABco+i5IDRJfsxaYFtTDQCT1nweP UKPMI1jutuRKBdAtKhPW8pWHDJuAN/+0nE26eebQJNexvF9zvYzBwOqBhzqahsPDWX/ZjsROjL/ SEsJqZqp9YB+r0RI3HuBA3UZXHKzuPGWxT1XyDPa3ABMCob5fv6d9/MLS8RWJqmZf/YsxjCyNGe 3YrjXBU+pgmsl2vTJUUoip8ublFdAvcjKkuvBHXiZFHIihQnlQea/Z4KOkFHes4n8gtTncTHjzY efljfCexQYfdPAH0GTw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-10_03,2026-02-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602110081 On 2/11/26 6:43 AM, Krzysztof Kozlowski wrote: > On Mon, Feb 09, 2026 at 02:24:25PM +0000, Srinivas Kandagatla wrote: >> From: Alexey Klimov >> >> Qualcomm Agatti SoC has PM4125 PMIC, which includes audio codec. >> Audio codec has TX and RX soundwire slave devices to connect to on-chip >> soundwire master. >> >> Add missing qcom,pm4125-codec compatible to pattern of audio-codec node >> properties in mfd qcom,spmi-pmic schema to complete the audio codec support. >> > > That's v6, not v1. Thanks Krzysztof, I was skeptical about it before sending however it made more sense to include that binding into this series which had 3 new patches,which is why I started of with v1 again. Which can be easy for review and dtb checks to not fail for the dts patches in this series. Am happy to send it as v7 next time as a single patch if that is what is prefered. > >> Signed-off-by: Alexey Klimov >> [Srini: reworked the patch] > > Why? The v5 version was what we wanted. Why changing it? > I looked at all the versions of this patch before sending out this one, it sounded that you were not okay with the patch itself, may be that is not true, you just wanted a clear commit log changed. I can send a new version with updated comments as you requested. May be I miss interpreted it your review on v5. TBH, there are multiple ways to add this new child node bindings into spmi bus. Just from my understanding, why listing compatibles is preferred over listing ref to child bindings?, while both serve the same purpose. thanks, Srini > Anyway, same feedback. > > Best regards, > Krzysztof >