From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6191F2D3226 for ; Fri, 2 Jan 2026 10:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767348538; cv=none; b=oBL7CXRV62LYJS86TqRqX3cbAFjz4eAaEQAwhMvBJ7rn6hYOVEiIth6UIDEnEiMJ0K8LjPob6e9B2PcZuohw5bJd4BgXm921HQtBMR54o1ihwaTMIIxUAjMrfdg/2yNTxsfIJwU4EiEZgV0QR4px8nfVxJthCSHS+eK3iEtLsU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767348538; c=relaxed/simple; bh=L4tcvySOgU3eAEJIA3ih73atfdDG2PceOZkHL6fp/1E=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=F5bAKVnKSIODQA275Z1Tuis41EqGTjWGIdBwisU4+AYfOx8IOOpJVFoXqN5NjjmYKgy+UD+I04C7lrq2PE4q3SGrQMXuKSclZTnD12L+VteZKBaxFK6We3B2n42Q5ujeuFy1XI6WZ/lKoGvFMy9jmBzIuRJT19J3cRFOLS3uZGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mP4yLnmS; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mP4yLnmS" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7d26a7e5639so13556640b3a.1 for ; Fri, 02 Jan 2026 02:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767348537; x=1767953337; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Fe815HykdJZXA/fdLXFlCD8aMFUo2cB4//CLLF3EANo=; b=mP4yLnmS+ZlMo1IhR3s3yyZbzK8L4d5Y6EdNh5QjUcrkUUMELpaVcCq2SnkXVRKwHc V1vxMbDkL9xEnV96ag8NOwKKzn6yQj5v9DlobRJL6f5cDkTS0Cyus5HL6+rovB1PJMEl sedi2NNWZSBJvrJxAjoteRD2sBeklffjMOiGUYWFlmEMlerWchdTY4T7emzuqL3ebWxY JddFtkiVmNVnEaZSa6FOWDjz8Zj0G96zbv4EKyozytOyiFCv40l5cu61xjyc8ckfRLXr 73Hg115FmFzvmny1nkMLtTYujLPxa6mQUGa0f5YuLz00vgdH6LgYTBpC7YEck57D5L/s D5PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767348537; x=1767953337; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fe815HykdJZXA/fdLXFlCD8aMFUo2cB4//CLLF3EANo=; b=FfIwNhCtZL4zTIBpZyNTU5eRHewES9I6bia3m7/pgVldi4mbaiy5mT9rFKSjkE5lzJ htPGyZR1mzrjCIyYUGhVfIofzBYY0hrg/yKX1wwagXtGenBWYKWyMgDBkFoUJl4Q42Z1 LxXxi9hFmxDfvalYTI2gU9eSQtnLwyJ2vHGoSHmHh8hwebhJ/cUdmyU3U058p6ISPqeQ vaucifQ55UYwhXam2FXHNeWMspBCag7yETvGZwm+amPEcaNq5ETnlgpNnwKOF9oeIsr5 E/IKFr6Nfki1CXMbB/t8oqjTt7LjRV3EZomA/XCTmeALe39YLHrxwp43DQaGIqvJdQ5U cCVQ== X-Forwarded-Encrypted: i=1; AJvYcCWWJQJRfhlPgahkuCjYrYeZ2bV1zBK6fTd3bDfN/6OCh3ynGdYXZFiwuq4ZTjjytSm0fcrkJBoBAgxb4O8=@vger.kernel.org X-Gm-Message-State: AOJu0YyZnxfpJD/396KQ0dRWfd43VdFBKioTuqEsytZJE4rDaX7Dd23C 2AL/aqb64RoGKEq1H09J25jQQUjRV9Kb3uCi8w4u+regO963pCVSrVkg X-Gm-Gg: AY/fxX57J6SefQdY9eyZWbWVZcMfY5LAyuog9nUxluGB+aRBFvdQepbwtJnMG7hB+C6 s4eo++NLMkB9tEhVa+DbuIdPj3YIwZVA/QAu5mXpxAMHdksZcAfEOQN1/anIkOxnNTzz/Lfukrl rRfHRv0Wiepnjddan1ecTzR04+pSBNnHkOsIx3IGn5kZ154wssMGgqInimT6xULI5pe8TB57+zo s2/AIWTvooxwxOpKloEKI/al09lDqFWnqSofMEjVz/pd1I4Pu+YyOKZCG4/Yiy3kT/eA/QNVwo5 /Zwe4wx/aYAS27sqMIlefTi1619pHYVoYy8OHp5ETKYFnM0iUOs1ilteqU2SXskfazFlR3qFh/I SIXDLhq3o8Lk2Xef4jLddlHzSKa23323BMjtRTuRNGvBFUecgHQJfDn/0k0pwp4Hj8wNtMVMSkw kEBKJwaWocBYmXgyI6U0O6RuWLA6txKdyH/em3uShwKslJmX1AXEvtmcIJbHBDK76Gd2NK6qM= X-Google-Smtp-Source: AGHT+IEC3e8kZw0Xj2yo5CTUSmbZNoTyCva9yA0VvjTLMoX4LlaMc1sV53Z/kNwFsdK4byE3LWwxlw== X-Received: by 2002:a05:6a00:418a:b0:7e8:450c:61b7 with SMTP id d2e1a72fcca58-7ff6607b8dbmr36213357b3a.39.1767348536655; Fri, 02 Jan 2026 02:08:56 -0800 (PST) Received: from ?IPV6:2401:4900:883b:60a8:c545:bc1e:eac1:a2b4? ([2401:4900:883b:60a8:c545:bc1e:eac1:a2b4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48cd07sm40045029b3a.46.2026.01.02.02.08.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jan 2026 02:08:56 -0800 (PST) Message-ID: Date: Fri, 2 Jan 2026 15:38:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema From: Akhila YS To: Krzysztof Kozlowski Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251229-nxp-v1-1-a415fe0080a8@gmail.com> <20251230-kagu-of-scientific-enrichment-6fcd4c@quoll> <0363ac61-0872-42da-91b8-78966a2537ce@gmail.com> Content-Language: en-US In-Reply-To: <0363ac61-0872-42da-91b8-78966a2537ce@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 02-01-2026 13:47, Akhila YS wrote: > > > On 30-12-2025 18:02, Krzysztof Kozlowski wrote: >> On Mon, Dec 29, 2025 at 12:49:00PM +0000, Akhila YS wrote: >>> +--- >>> +$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Microchip 23K256 (and similar) SPI SRAM MTD driver >> driver? Bindings are for hardware. > > > Sure, I will fix it. > >>> + >>> +maintainers: >>> + - Richard Weinberger >>> + >>> +description: | >> Do not need '|' unless you need to preserve formatting. > Ok. >>> + Driver for Microchip 23K256 and compatible (e.g. 23LCV1024) serial SRAM devices >> Don't describe drivers... >> >>> + accessed via SPI. The device exposes the SRAM as an MTD device and supports >>> + optional partitioning via child nodes. >> nor DTS, but the hardware. > > > OK, I will change it. > >>> + >>> +allOf: >>> + - $ref: /schemas/spi/spi-peripheral-props.yaml# >>> + >> If this is SRAM, then it should go to sram directory. But maybe it is >> MTD, so NOR or NAND? If so you would be missing here refs to NAND >> chips. >> >> Although docs are saying it is SRAM, so just place it there. > > This SRAM is not generic MMIO SRAM, it's an SPI peripheral exposing > memory via the MTD subsystem. Also i tried Yaml from sram directory it > doesn't work with it. > >>> +properties: >>> + compatible: >>> + enum: >>> + - microchip,mchp23k256 >>> + - microchip,mchp23lcv1024 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + "#address-cells": >>> + const: 1 >>> + >>> + "#size-cells": >>> + const: 1 >> Pretty incomplete. Old binding and above cells claim there can be child >> nodes, so please add them and test. Works? No. Shall work? Yes... so >> either old binding was incorrect or new binding is incomplete. I did not >> check the driver, though. > > > Size cells and Address cells are not required as there is no child > node and I tried to define child node , Included SRAM.Yaml as a > reference file and tested it. It doesn't work. > >>> + >>> +required: >>> + - reg >>> + - compatible >>> + - "#address-cells" >>> + - "#size-cells" >>> + - spi-max-frequency >>> + >>> +unevaluatedProperties: false >>> + >>> +examples: >>> + - | >>> + spi { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + sram@0 { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >> They are redundant. Where are children? > > > They are redundant, There is no child node  and i will remove it. > >>> + compatible = "microchip,mchp23k256"; >>> + reg = <0>; >>> + spi-max-frequency = <20000000>; >>> + }; >>> + }; >>> +... >>> >>> --- >>> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8 >>> change-id: 20251229-nxp-526e29da9f29 >>> >>> Best regards, >>> -- >>> Akhila YS >>> -- Best Regards, Akhila.