From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF8DC43460 for ; Mon, 17 May 2021 07:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 285C7601FA for ; Mon, 17 May 2021 07:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235259AbhEQHxZ (ORCPT ); Mon, 17 May 2021 03:53:25 -0400 Received: from mga04.intel.com ([192.55.52.120]:9143 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbhEQHxX (ORCPT ); Mon, 17 May 2021 03:53:23 -0400 IronPort-SDR: Myar4+xNKHXjO5hTvAxfotLwVnogwRQjWXdGcX7aEqHhKRRhiJkeGxAQQVpFlTQzViE9A0IShj OZCf0pweUzzg== X-IronPort-AV: E=McAfee;i="6200,9189,9986"; a="198453743" X-IronPort-AV: E=Sophos;i="5.82,306,1613462400"; d="scan'208";a="198453743" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2021 00:52:07 -0700 IronPort-SDR: rd21XUZcwHIbvmiOSea5rvnjWierU/LWoSiQ3oORaaOmyAIa2WowbgOIqQrWXlo2U6YudJplIL yhh50sy9U1iQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,306,1613462400"; d="scan'208";a="460213344" Received: from allen-box.sh.intel.com (HELO [10.239.159.128]) ([10.239.159.128]) by fmsmga004.fm.intel.com with ESMTP; 17 May 2021 00:52:04 -0700 Cc: baolu.lu@linux.intel.com, sashal@kernel.org, ashok.raj@intel.com, jroedel@suse.de, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [REWORKED PATCH 1/1] iommu/vt-d: Preset Access/Dirty bits for IOVA over FL To: Greg KH References: <20210517034913.3432-1-baolu.lu@linux.intel.com> <726aede1-3d9f-6666-b31d-9db8e4301a0c@linux.intel.com> From: Lu Baolu Message-ID: Date: Mon, 17 May 2021 15:51:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On 5/17/21 3:27 PM, Greg KH wrote: > On Mon, May 17, 2021 at 03:17:53PM +0800, Lu Baolu wrote: >> Hi Greg, >> >> On 5/17/21 3:07 PM, Greg KH wrote: >>> On Mon, May 17, 2021 at 11:49:13AM +0800, Lu Baolu wrote: >>>> [ Upstream commit a8ce9ebbecdfda3322bbcece6b3b25888217f8e3 ] >>>> >>>> The Access/Dirty bits in the first level page table entry will be set >>>> whenever a page table entry was used for address translation or write >>>> permission was successfully translated. This is always true when using >>>> the first-level page table for kernel IOVA. Instead of wasting hardware >>>> cycles to update the certain bits, it's better to set them up at the >>>> beginning. >>>> >>>> Suggested-by: Ashok Raj >>>> Signed-off-by: Lu Baolu >>>> Link: https://lore.kernel.org/r/20210115004202.953965-1-baolu.lu@linux.intel.com >>>> Signed-off-by: Joerg Roedel >>>> Signed-off-by: Sasha Levin >>>> --- >>>> drivers/iommu/intel/iommu.c | 14 ++++++++++++-- >>>> include/linux/intel-iommu.h | 2 ++ >>>> 2 files changed, 14 insertions(+), 2 deletions(-) >>>> >>>> [Note: >>>> - This is a reworked patch of >>>> https://lore.kernel.org/stable/20210512144819.664462530@linuxfoundation.org/T/#m65267f0a0091c2fcbde097cea91089775908faad. >>>> - It aims to fix a reported issue of >>>> https://bugzilla.kernel.org/show_bug.cgi?id=213077. >>>> - Please help to review and test.] >>> >>> What stable tree(s) is this supposed to be for? >> >> It's for 5.10.37. > > But the above commit is already in 5.10.y. And what about 5.11 and > 5.12, were those backports incorrect? Above commit is now only in v5.10.37. Other 5.10.y are not impacted. 5.11 and 5.12 both have correct backports. > > confused, > > greg k-h > Best regards, baolu