From: Pavel Skripkin <paskripkin@gmail.com>
To: Dongliang Mu <mudongliangabcd@gmail.com>,
syzbot <syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
rafael@kernel.org,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: [syzbot] memory leak in __mdiobus_register
Date: Tue, 28 Sep 2021 11:15:24 +0300 [thread overview]
Message-ID: <cfec2c6f-34a9-d95e-5f07-c69e74b06450@gmail.com> (raw)
In-Reply-To: <CAD-N9QUJWifqhNt09xDcu=w0K0o+wYUxpZyqkTs4q5eMp_kVgw@mail.gmail.com>
On 9/28/21 10:42, Dongliang Mu wrote:
> On Mon, Sep 27, 2021 at 7:44 AM syzbot
> <syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com> wrote:
>>
>> Hello,
>>
>> syzbot has tested the proposed patch and the reproducer did not trigger any issue:
>>
>> Reported-and-tested-by: syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com
>>
>> Tested on:
>>
>> commit: 5816b3e6 Linux 5.15-rc3
>> git tree: upstream
>> kernel config: https://syzkaller.appspot.com/x/.config?x=41799858eb55f380
>> dashboard link: https://syzkaller.appspot.com/bug?extid=398e7dc692ddbbb4cfec
>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
>> patch: https://syzkaller.appspot.com/x/patch.diff?x=1147b840b00000
>>
>> Note: testing is done by a robot and is best-effort only.
>
> Hi Pavel,
>
> Confirm the patch you posted [1] is the real fix of this bug report.
>
> I tested the patch from Yanfei Xu [2] in my local workspace, and the
> memory leak is still triggered. In addition, I have pushed a patch
> request for that patch. The result would prove that patch is not
> working for this bug.
>
> BTW, there occur incorrect fix commits on the syzbot dashboard
> sometimes. Maybe it should be cleaned in the future.
>
Hi, Dongliang,
thank you for confirmation. As I said in reply to [1] Yanfei's patch is
also correct, but it solves other memory leak in same function.
AFAIU, if my patch will be applied too there will be 2 fix patches on
syzkaller bug report page, so no need to remove Yanfei's patch from bug
report page :)
> [1] https://lkml.org/lkml/2021/9/27/289
> [2] https://www.spinics.net/lists/kernel/msg4089781.html
>
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-09-28 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 1:28 syzbot
2021-09-26 23:27 ` Pavel Skripkin
2021-09-26 23:44 ` syzbot
2021-09-28 7:42 ` Dongliang Mu
2021-09-28 8:15 ` Pavel Skripkin [this message]
2021-09-28 15:39 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfec2c6f-34a9-d95e-5f07-c69e74b06450@gmail.com \
--to=paskripkin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
--cc=rafael@kernel.org \
--cc=syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®