From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914AbdGNLZw (ORCPT ); Fri, 14 Jul 2017 07:25:52 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9773 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753831AbdGNLZt (ORCPT ); Fri, 14 Jul 2017 07:25:49 -0400 Subject: Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock To: Ilya Dryomov CC: Sage Weil , Alex Elder , Mike Christie , "linux-kernel@vger.kernel.org" References: <1499931995-64900-1-git-send-email-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: Date: Fri, 14 Jul 2017 19:25:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.5968AA36.0186,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ceffc0e644d25519d32a15616c1dd98e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/7/14 18:06, Ilya Dryomov wrote: > On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang wrote: >> drivers/block/rbd.c: In function 'rbd_acquire_lock': >> drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] >> >> Silence the warning, found it when built old kernel(3.10) with >> OBS(opensuse build service). >> >> Signed-off-by: Kefeng Wang >> --- >> drivers/block/rbd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c >> index b008b6a..b640ad8 100644 >> --- a/drivers/block/rbd.c >> +++ b/drivers/block/rbd.c >> @@ -3435,7 +3435,7 @@ static void rbd_acquire_lock(struct work_struct *work) >> struct rbd_device *rbd_dev = container_of(to_delayed_work(work), >> struct rbd_device, lock_dwork); >> enum rbd_lock_state lock_state; >> - int ret; >> + int ret = 0; >> >> dout("%s rbd_dev %p\n", __func__, rbd_dev); >> again: > > How did you get rbd_acquire_lock() into 3.10? Using CentOS 7.3. > > Thanks, > > Ilya > >