From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: "Hsin-Te Yuan" <yuanhsinte@chromium.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>
Subject: Re: [PATCH RESEND v2] arm64: dts: mt8195-cherry-tomato: change watchdog reset boot flow
Date: Tue, 23 Jan 2024 11:38:42 +0100 [thread overview]
Message-ID: <cfee57f3-5940-44c3-a93b-3a5160dc8351@collabora.com> (raw)
In-Reply-To: <CAGXv+5H-mpXZ_0H_HchDWeTgx+4Nkxh6651DEs1C62mrXczTkA@mail.gmail.com>
Il 23/01/24 05:03, Chen-Yu Tsai ha scritto:
> +CC Nicolas
>
> On Thu, Dec 28, 2023 at 6:57 PM Hsin-Te Yuan <yuanhsinte@chromium.org> wrote:
>>
>> The external output reset signal was originally disabled and sent from
>> firmware. However, an unfixed bug in the firmware on tomato prevents
>> the signal from being sent, causing the device to fail to boot. To fix
>> this, enable external output reset signal to allow the device to reboot
>> normally.
>>
>> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
>
> Friendly ping?
>
> Also wondering if you folks hit this, or if you haven't triggered the
> watchdog at all.
>
I have never seen any watchdog timeout on Tomato R2.
In any case - this commit misses a Fixes tag...
Cheers,
Angelo
> ChenYu
>
>> ---
>>
>> Changes in v2:
>> - Limit the effect only on tomato.
>>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts | 4 ++++
>> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts | 4 ++++
>> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts | 4 ++++
>> 3 files changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
>> index 2d5e8f371b6d..a82d716f10d4 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
>> @@ -23,3 +23,7 @@ &sound {
>> &ts_10 {
>> status = "okay";
>> };
>> +
>> +&watchdog {
>> + /delete-property/ mediatek,disable-extrst;
>> +};
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
>> index 2586c32ce6e6..2fe20e0dad83 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
>> @@ -43,3 +43,7 @@ &sound {
>> &ts_10 {
>> status = "okay";
>> };
>> +
>> +&watchdog {
>> + /delete-property/ mediatek,disable-extrst;
>> +};
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
>> index f54f9477b99d..dd294ca98194 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
>> @@ -44,3 +44,7 @@ &sound {
>> &ts_10 {
>> status = "okay";
>> };
>> +
>> +&watchdog {
>> + /delete-property/ mediatek,disable-extrst;
>> +};
>> --
>> 2.43.0.472.g3155946c3a-goog
>>
next prev parent reply other threads:[~2024-01-23 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 10:57 Hsin-Te Yuan
2024-01-23 4:03 ` Chen-Yu Tsai
2024-01-23 10:38 ` AngeloGioacchino Del Regno [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-18 4:51 yuanhsinte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfee57f3-5940-44c3-a93b-3a5160dc8351@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
--cc=yuanhsinte@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®