From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F7B639020C for ; Mon, 8 Jun 2026 08:11:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780906305; cv=none; b=C8ZPrlOM3Vtx3BI7/i9sjyLjZ4EDRXksNZt/KRpqoCAND70vOLa/38s1/7qjZjBxqmEkzfBhFlkMnEx+ZgmjFzZpp+BHMLPltXTUBpUYKr+K1EwB6bQPdb7wIy4I0j8DYEkZ96HSd17TcMP1Mmg5EDRVjytD6SV4FJ6tmW96+nA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780906305; c=relaxed/simple; bh=7QGjeYp+lVN3mkoIQkK7bjs46BHL5k9kHYo5n235j/o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r2ys479UlxDvxsWGd7ufzknWPGOWnB59HSce0WTR1G/WacGDfCOthmpbTJJ79TJTnn6I3MK8iwDR6FJJeSV+q6j0uFXDa2xlRglVcfN9RzfltdnSaGwHffMp6DbSdZ8d5x7p0+1r02pom1R/2YHsz0gEjX00MJPzqnsMxLgpuDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l9DsxP1+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AaFufeO8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l9DsxP1+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AaFufeO8" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586Ou0M2833003 for ; Mon, 8 Jun 2026 08:11:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s+HZQmCjytazYLSvvHY/io1wridXfLJz+czVsgR52vQ=; b=l9DsxP1+dDB/MnJ3 X8rsY8/xOhjKoGh2ZydtIl/B5hi+BaJEjBSeQnh8ekFa6u+BQPYm1zupZsbob5lu scewVj3UX0wLBDimrY0DG1eL1xoN9mrIzIjALsrcLR7BYL4fkIG7Z9WN7a++zHJl ihGq0pFIjyrr2ldZuJPKVATY+q7slQzBQ+NEAyWxH5cLxhGeeHuGFcZrw0HVf8bT e48rg/Ctg8dM3f1NwJKMURSs3lPEawXQm8KbnZIV9ET+aR+pb0F9VQXyJjQpeXHw RQR/j71BBcA4Yve0OPI4YuqD/eW9wXWNnDI3xa7o4WWKzPn1Nj2c/HoAXY3m/Ed8 Zto5vw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4embmrervj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 08:11:42 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-517bdeceb54so1107211cf.2 for ; Mon, 08 Jun 2026 01:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780906302; x=1781511102; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s+HZQmCjytazYLSvvHY/io1wridXfLJz+czVsgR52vQ=; b=AaFufeO86pLpReJdNRsv4XIHWyiA8jKjx8UaE5aHBnYuKDVJQQ+CN+jrNmFZRv91I+ Uyxl+BddllDfN99xf3PIB1Dw/rcPtzpXJovlGh9KdbZ7ENZzXckY55M1tTAEhm4w4/oo d6RIEq2uw94bCm5RQ+Ihclm5/mK/8vge93wH9V5F1uTg/q3M/bpN0GzJaKzdFyw8FmX1 +1gZHOsDvsxR+dsx42vBg8J+CrNfAbmTqVx666wKXW/70vwnH5ZWMqnQqUwbKx7fgMyi o0qKySqBHfEgJSOcCOuh2R5h0EJ3sPqeHAoBQLsyNbexizfEYDCvkYYrezdi6sst7fVg zxEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780906302; x=1781511102; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s+HZQmCjytazYLSvvHY/io1wridXfLJz+czVsgR52vQ=; b=M+pHcvd7ztoLD62M6D46V/+lHMtf+11hx6vNDU8d9KZ4BYPeByhYD0zjuSQRUnsAkJ dhz6QA4BNXYv39VoFBVpfi5zURuUpaTIa5tx1Ph6lLdd1vkZ4U3xx1tcmLWcwSoBaCC4 xbYV0YgdrBV6HFSKHkqlxuX2W+b8oClC/kTq0yT+zNH5u0A4p/tVysecWpmBJkSEDsv5 d0wCzfwy0cvbO/gM0OdQ42c1qVzKmiYSh5aZF/4yDEua0/47RL+Y0ZsGUzkF4ut9G5Wv D8tMAleYK/wKgFnjB/G/f4TTeNrr2Z+OfjtKzIX4B5/ltfHbi8SrOqY1K4Dn8gR77Omg Toig== X-Forwarded-Encrypted: i=1; AFNElJ8Ujk3JAqCBRdg20oH9ZenDnoKyhuKFUXa6AlZPDkQvCgawxdgnmXcUaz2IbsCYf4NDtNi7xHiE7hkxmUc=@vger.kernel.org X-Gm-Message-State: AOJu0YxGdZiuvw/2FLMJVyOJ34pobl+WbVrKkWAePfmkCHYWEgMdPQfr LcTCnbyufNcbyeVw85aw6B2a9vsOLqk/pOgHQH98FkymKWgDOqm0vbQxv95Txgagp/86v4ECaJw X9GeVd6xbQE+7+VXIbn8E84IiNgvcL70ZocXgc1QnPEpzRs/ZZM0fAzmMvNmvSuW6vus= X-Gm-Gg: Acq92OE26dzqerpqGrl/hwPsy+bznmqB6M0jnabPDbL68zYxU3ieFMO0sfNg4cz01AW gd2RnkyCqTgHSbAjzfs6RTi5GxHWC+CC0/oq23dESkf1ap282HoO+P6i9ZHy6Z2Ody7LG5jhduy PDBlgBmrlV4HNM+kT4x5zqqqpJ9yOaAFVwjLFrU/6koYwQ1IKN6qF9aRTsi8fsdvdyVc5QTvxZu D3wgGeO8WoTnrT6ysNpbxWkszEXrRsT77fqbE5D3Z08MIL5/MRUguWW487vwjBY8zt/xhYiqiBe r/eKhv4Rl9sY2RpC5DvQqeyIVXNvrJ/viUdaAX4yjIlRd5ctqUOCArTU6OJy1qJ6rdCjIqdaSO/ qnzz01uZ4dZPWnAQqoE9lIbO/PO8Ai5qEBgdJLqN4VaLoW8a8DkSrOsQ1 X-Received: by 2002:a05:622a:120b:b0:50d:9138:3322 with SMTP id d75a77b69052e-51795bebe2dmr136988641cf.7.1780906302363; Mon, 08 Jun 2026 01:11:42 -0700 (PDT) X-Received: by 2002:a05:622a:120b:b0:50d:9138:3322 with SMTP id d75a77b69052e-51795bebe2dmr136988431cf.7.1780906301968; Mon, 08 Jun 2026 01:11:41 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf0559f1f62sm840014066b.57.2026.06.08.01.11.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 01:11:41 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 10:11:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] drm/msm: Recover HW before retire hung submit To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Puranam V G Tejaswi , Jie Zhang , =?UTF-8?Q?Ma=C3=ADra_Canal?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jie Zhang References: <20260605-assorted-fixes-june-v1-0-2caa04f7287c@oss.qualcomm.com> <20260605-assorted-fixes-june-v1-2-2caa04f7287c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260605-assorted-fixes-june-v1-2-2caa04f7287c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA3NCBTYWx0ZWRfXyKGuM7UYFGOY bEvZ84wg/GigWWwroMoGtnPB2Br65C0WqJ6JvU/zAXs+DZPQwUvsB4LYsjAHUyOAKaa7JOG5e08 OtfEXI9fcBW8bqNpzUCKO+8+DlKDVeLRTx9pFL8mUp1yY3G+7CfnX+y1qFEPKKdPfX/g09nmPIi 5cfpxdKo0nG0kAqH1Aw1ZOxXzv0U9lNICmcaENaFPyusIaZpocEWkoAZA4wt3Se27V+wYhsuX5+ 8c6pGcffBnedwyuHVMGu/tDUwAQdmrCF6ItWwXFjqM/1OVt8gqXmYvyLoRaGcTV4bbSLhw86JYC 6YlEtYHkS7zDuPDPQz5IH3sClhqpBvMtKVovNvm3sD/Ke28Ve0/uwyHBDr35bBzX2r3HjD90TPS 85R1MEnlMWkrZ1tPpIuNWNuHcPtxVjvgHg4fpoJ7LQ5E0dFwdYylAt5sd8hU7vyse1O51YKXAia wI/953lNzIdqXcwkVVw== X-Authority-Analysis: v=2.4 cv=B5eJFutM c=1 sm=1 tr=0 ts=6a26793f cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=1CK4PI73WE-LNi9EeHwA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: O4uyKuUELgFo5DwX9NUhIaKZNzxTFkpc X-Proofpoint-ORIG-GUID: O4uyKuUELgFo5DwX9NUhIaKZNzxTFkpc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080074 On 6/4/26 10:08 PM, Akhil P Oommen wrote: > From: Jie Zhang > > During recovery, it is not safe to retire the hung submit before we > recover the GPU. Retiring the submit triggers BO free and that can > result in GPU pagefaults since the GPU may be actively accessing those > BOs. > > To fix this, retire the submits after gpu recovery is complete in > recover_worker(). > > Fixes: 1a370be9ac51 ("drm/msm: restart queued submits after hang") > Signed-off-by: Jie Zhang > Signed-off-by: Akhil P Oommen > --- Acked-by: Konrad Dybcio Konrad