From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C60E38239C for ; Thu, 25 Jun 2026 09:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782379235; cv=none; b=gKiZD++wGsvt037bVDVK/cNd82xNramtQ159sjsZXsf/IN9RGjPrEuX1efOzPkJKqAfOxKRj5y2jAtjrdXoYEAHWWXpQRhm1o1RlgMsU3YWgbXhlTi2Kgvgqt+gg48fMx/YGhWEU4Z/0RMtCUpsDLDI+OwHXyHr9YuLJGtfESo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782379235; c=relaxed/simple; bh=a5gHmSxXk0EM6GiLK8Z+ZY9byqUmLddQvQJnA9muWik=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nVc781HpTTKbaTSynzTxGm61E+apt7WT5nqK/TOa3fFSneI1HowMn5C2ITaf7pyQIMghLvWdak8PntjPxm5UHpgLIw2mTz5kI/tiL2Q2TU8A0I3mKIW+3rCJrkuNEWS3KtAopN9PywuG4v0wEIQEU4xO9Z6kJIO+AG9F+WbwtrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I3NdIUAt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BYZ47hO/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I3NdIUAt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BYZ47hO/" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65P8pbrv1345906 for ; Thu, 25 Jun 2026 09:20:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= G6owLxNlPkAyRM/9IkXm18k3Rl3GttwQeKqnecszV0g=; b=I3NdIUAtndd/nf4W E5mbzdnvQK14a4uUHqC3uWz9nRbLTxCTI2AJu0nWgQfxg8TutVVPs0/AHuqKiiYH i7saDfRYRh9017GAaovEi5orCvrdjUNrD2qE60KAKl+Daz12d0mDN3h84WyrzUDj CpcE5iXPm3RsagFjOlGFgAJt2GwwDctIjx1RJeJ4PA9mOBqHakATYnYZmMOEtmBE XclWfZ3xSZVG/a0p/rE5kOj0sAcF7aeew67URAsOrrstTkqpkHzC2IcUWS6d8FuF d3w0shW2LyKWdSgeB0oStGEhLodzHzusXfKHvQhMaDl0YHnI6h3hMw4CrU89D2Sb sGpfrw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0nv7jm76-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 09:20:33 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8453e61d6f0so2102156b3a.0 for ; Thu, 25 Jun 2026 02:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782379233; x=1782984033; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G6owLxNlPkAyRM/9IkXm18k3Rl3GttwQeKqnecszV0g=; b=BYZ47hO/1Zxlxnq126OZ0LAr6AxEsYB2RAJwb6U+nrFsgEpwYA1hx+WVZD1yT8xLyT P0Ks6EatwLYxiLxu40CQs6IFzsu059GM0tqKVIPmWFFrETIxnSn1xQy46R7kLdF74vZ8 pVKWsj8F6OHrcPEgOlWxvEj+VyAcwlZaUXOWJsvQ9QBgWnPtlXv55gy+07PXqKj+gYwm cA8w3ZugNpk4g39A7GqS+G63DoZOgaMtk9neaZGhRfdnLfYGyBeYAH905uFUfjtIgu96 6VXob22d4YWjo+lQItKQler5h2ShyEWL3GmUd2pseUWJAIQHCiI9MuO+mwSIMFdwl3ZH 8/JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782379233; x=1782984033; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G6owLxNlPkAyRM/9IkXm18k3Rl3GttwQeKqnecszV0g=; b=B+aUEvAnknwpl5Xg3su6OVvsBA+zhPGxY9qLLNOYAl9fK5A5blV3PNt1a8lDCU8uz8 6lXPH0hWRAtnfPN81PZEkakFHCDkWJ0Ws1JOgLliFE949I0C3cGXGkmmohtedYt5Uwgq O5Gj7ZgCvhnWVIBFhzdAT8nRjyO2ItzlpDPRSPtmRYb+T6O/6itKf6DFZRQEoJ1OknjB EkmDQlZP13+iur2Wu+k29ufxadvnNYhDfnrQFdh6lBqmyi4UYvilYb5RqrIye1o1fvWj A9sqpTKzlm+AkATjPGmdCiz5DkHPiSNGnYTK3KW6r6T5jxEqSXoMz+B7rKb5utiSJZV5 JzSA== X-Forwarded-Encrypted: i=1; AFNElJ8C0jgeKKxDGcsJjX5XLaceE6Yqf1sRbf0kS3DI97L+sfY098i+smNTTVNnOGJW6UkR0aJJuXcwOfFX8CI=@vger.kernel.org X-Gm-Message-State: AOJu0YyWduRsYAlHQDv634yJWSq8KTfGDntKDf9ABWOiZQeSMUxaSQkU o7+ky7qyih6Z1+uEnh8KvdDCAsq2fPGLPZV1vMdVGL/geZ5nCmJnBNgeeS4q5x45KmujfAEIRHY GmjTqUxwged9NV+Rc9K8T5L2KxmQF7h8BEq0yKhsu+mkKv+uEFDOiKUzRO7THI+8eKQk= X-Gm-Gg: AfdE7cmMHaYRx9QFT6cJyv9eT8aV8BJhWOe9OEditBe112GjFlDue7K4rLtbPnptoQ7 Lw2Isp6RWhXNGuajdBi6LWZ8HXH9nFQqSNf7SVvzSnXj6C1NS8D7a2j35n4DpD2SCySmUORE9py 2NW5fcUA96vxZjR0NqyRKFAUeJ3Lh43ECtnGw6NKE1bwus/HDn7oG+oIKflAiTD3+3DiL8FfGtV 0hmhBXPmL7+ixUdbVEj+SyBcTWCcH4V8elgIB/uNmeFffWAtzo1K4Jw3p/TnR2fUOnLADTuD/12 C8Z1kKzyUIUyFFjnZl3cUuJ9AabQLX5VR1+lRHUUgz/hx4mN6pHfSZb6oaIIzTMm3yNyqFWJGxN oEbkGGlGx1JkCz3ew6bF/1Jahf1ZjVL3nyBH0mg== X-Received: by 2002:a05:6a00:340e:b0:842:6fac:bd3 with SMTP id d2e1a72fcca58-845b3aae9bfmr2112860b3a.28.1782379233041; Thu, 25 Jun 2026 02:20:33 -0700 (PDT) X-Received: by 2002:a05:6a00:340e:b0:842:6fac:bd3 with SMTP id d2e1a72fcca58-845b3aae9bfmr2112819b3a.28.1782379232532; Thu, 25 Jun 2026 02:20:32 -0700 (PDT) Received: from [10.218.48.36] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-845a3fcc696sm4340835b3a.4.2026.06.25.02.20.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 02:20:32 -0700 (PDT) Message-ID: Date: Thu, 25 Jun 2026 14:50:26 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/8] irqchip/qcom-pdc: Differentiate between direct SPI and GPIO as SPI To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad References: <20260616-hamoa_pdc_v3-v3-0-4d8e1504ea75@oss.qualcomm.com> <20260616-hamoa_pdc_v3-v3-4-4d8e1504ea75@oss.qualcomm.com> <2978f55b-0b5c-4720-98ba-e14ef46b1169@oss.qualcomm.com> Content-Language: en-US From: "Maulik Shah (mkshah)" In-Reply-To: <2978f55b-0b5c-4720-98ba-e14ef46b1169@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDA3OSBTYWx0ZWRfX/E0ClHva0hDw jexqlnl4tdMhXpB43Hdqvg7bmRav2G4I9XOQfqRiEvxsc+1iiNXYzwnqbPAQzRe7/wRXfbnX1Lr uDefqnnBqzygpFEV5m5aIg1vpSZpeCA= X-Authority-Analysis: v=2.4 cv=RJiD2Yi+ c=1 sm=1 tr=0 ts=6a3cf2e1 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=fkzGnpFETygImC-9BAwA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: cqzWllNxudwO6VjHuWLQ_SJReR6i8Qd3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDA3OSBTYWx0ZWRfX5MsTiC2ypYpH 2WyAH0m7IdeiXAJPLDBSRiGIx44dO9R4SP2blBMY6TzNtJuWKLUbHPf6fRCQ9Beoyitn96LsET0 WAA8J1BOvooxfL20oxAYVkl9DoSYLVQ30kDoGjjKRoKxBPx6m02FtW/SVlgFb3xVPakXoLpR3Fn Y7cLW5C+GgH/eVmr9Ru59tvyhC7Oaa3tQS5e0qDkZqoD6m/D0Iw7yFwRZJELFBrXmLLWm2SlHto 8VxHgyQT/3OpBYxqYDlVajLLMKmcxexJCsdgUb8KV0fnLitWa3ix3DRLNQyqb/CQ8qlrxzQ8AoJ nlUUWSk9V1ChSruBiy8pPiqIbGHisgWF6yiLhdPzc/anBM+M/zNpP/RfFJW5arkMvA2sSwqPdLj osLVV9jnPy/M1Yob93MIZWPH1xgvfvXjNQs4eWugUtHmVwly68AxlKRRvXLpQtLjCQqQpMUbf9M FTmeENhTQKdh8jc4qKA== X-Proofpoint-GUID: cqzWllNxudwO6VjHuWLQ_SJReR6i8Qd3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250079 On 6/18/2026 1:32 PM, Konrad Dybcio wrote: > On 6/16/26 11:25 AM, Maulik Shah wrote: >> Before commit 4dc70713dc24 ("irqchip/qcom-pdc: Kill non-wakeup irqdomain") >> there are separate domains for direct SPIs and GPIO used as SPIs. Separate >> domains can be useful in case irqchip want to differentiate both of them. >> Since commit unified both the domains there is no way to differentiate. >> >> In preparation to add the second level interrupt controller support where >> GPIO interrupts get latched at PDC (but not direct SPIs) there is a need to >> differentiate between SPIs and GPIOs as SPIs. Reverting above commit do not >> seem a good option either which leads to waste of resources. >> >> PDC HW have the IRQ_PARAM register telling number of direct SPIs and number >> of GPIOs as SPIs. Further PDC allocates direct SPIs at the beginning and >> all GPIOs as SPIs are allocated at the end. This information can be used in >> driver to differentiate them. >> >> Add the support to read this register and keep this information in >> struct pdc_desc. Later change utilizes same. >> >> Signed-off-by: Maulik Shah >> --- > > [...] > >> + irq_param = pdc_reg_read(pdc->regs->irq_param_reg, 0); >> + pdc->num_spis = FIELD_GET(GENMASK(7, 0), irq_param); >> + pdc->num_gpios = FIELD_GET(GENMASK(15, 8), irq_param); > > num_gpios is not used in this series, please either drop it or > use it to limit the index in the following patches > > Konrad I will remove unused num_gpios from v4. Thanks, Maulik