From: gengdongjiu <gengdongjiu@huawei.com>
To: "Baicar, Tyler" <tbaicar@codeaurora.org>,
gengdongjiu <gengdj.1984@gmail.com>
Cc: Borislav Petkov <bp@suse.de>, <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
John Garry <john.garry@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>, <zhengqiang10@huawei.com>,
Xiongfeng Wang <wangxiongfeng2@huawei.com>,
Huangshaoyu <huangshaoyu@huawei.com>,
wuquanming <wuquanming@huawei.com>,
James Morse <james.morse@arm.com>,
Geliang Tang <geliangtang@gmail.com>,
<andriy.shevchenko@linux.intel.com>, <tony.luck@intel.com>,
<austinwc@codeaurora.org>, <shameerali.kolothum.thodi@huawei.com>,
<jonathan.cameron@huawei.com>, <huangdaode@hisilicon.com>,
<wangzhou1@hisilicon.com>
Subject: Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block
Date: Wed, 16 Aug 2017 16:03:13 +0800 [thread overview]
Message-ID: <cff53642-79bb-ea85-507f-28ba100ced73@huawei.com> (raw)
In-Reply-To: <3747a14c-0801-fe10-f36e-af6458fd7bdf@codeaurora.org>
Hello Tyler,
I have already updated a new version patch to adds this usage to cper_estatus_check(), please re-test.
Hello Boris,
The original macro of apei_estatus_for_each_section has two issues:
one is the iteration loop termination condition; another is the iteration steps. please review it.
thanks.
On 2017/8/16 7:26, Baicar, Tyler wrote:
> On 8/15/2017 3:34 PM, gengdongjiu wrote:
>> Hi Tyler ,
>>
>>> Hello Boris,
>>>
>>> His patch fixes the define for apei_estatus_for_each_section which in turn
>>> should fix ghes_do_proc(). So my patch should no longer be needed. I'm going
>>> to test this out just to verify if fixes the issue I found.
>> I have verified the issue about the iteration for the revision 0x300
>> generic error data,
>> it works well. it is good that you will verify that in your platform.
> I've verified that this resolves the issue as well! I'll re-test with the next version that adds this usage to cper_estatus_check() and add my tested-by after that.
>
> Thanks,
> Tyler
>
prev parent reply other threads:[~2017-08-16 8:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 11:15 Dongjiu Geng
2017-08-15 14:16 ` gengdongjiu
2017-08-15 16:13 ` Borislav Petkov
2017-08-15 16:30 ` gengdongjiu
2017-08-15 16:32 ` Borislav Petkov
2017-08-15 16:42 ` gengdongjiu
2017-08-15 16:55 ` Borislav Petkov
2017-08-15 18:31 ` Baicar, Tyler
2017-08-15 19:12 ` Borislav Petkov
2017-08-15 21:34 ` gengdongjiu
2017-08-15 23:26 ` Baicar, Tyler
2017-08-16 8:03 ` gengdongjiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cff53642-79bb-ea85-507f-28ba100ced73@huawei.com \
--to=gengdongjiu@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=austinwc@codeaurora.org \
--cc=bp@suse.de \
--cc=geliangtang@gmail.com \
--cc=gengdj.1984@gmail.com \
--cc=huangdaode@hisilicon.com \
--cc=huangshaoyu@huawei.com \
--cc=james.morse@arm.com \
--cc=john.garry@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shiju.jose@huawei.com \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
--cc=wangxiongfeng2@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=wuquanming@huawei.com \
--cc=zhengqiang10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®