From: Beleswar Prasad Padhi <b-padhi@ti.com>
To: Harikrishna Shenoy <h-shenoy@ti.com>,
<Laurent.pinchart@ideasonboard.com>, <airlied@gmail.com>,
<andrzej.hajda@intel.com>, <andy.yan@rock-chips.com>,
<aradhya.bhatia@linux.dev>, <devarsht@ti.com>,
<dianders@chromium.org>, <dri-devel@lists.freedesktop.org>,
<javierm@redhat.com>, <jernej.skrabec@gmail.com>,
<jonas@kwiboo.se>, <linux-kernel@vger.kernel.org>,
<linux@treblig.org>, <luca.ceresoli@bootlin.com>,
<lumag@kernel.org>, <lyude@redhat.com>,
<maarten.lankhorst@linux.intel.com>, <mordan@ispras.ru>,
<mripard@kernel.org>, <neil.armstrong@linaro.org>,
<rfoss@kernel.org>, <s-jain1@ti.com>, <simona@ffwll.ch>,
<tomi.valkeinen@ideasonboard.com>, <tzimmermann@suse.de>,
<u-kumar1@ti.com>
Subject: Re: [PATCH v10 0/6] MHDP8546 fixes related to DRM_BRIDGE_ATTACH_NO_CONNECTOR usecase
Date: Wed, 18 Feb 2026 15:04:50 +0530 [thread overview]
Message-ID: <cff8c928-9dab-49aa-942d-745d8b0fa75a@ti.com> (raw)
In-Reply-To: <20251209120332.3559893-1-h-shenoy@ti.com>
Hi All,
On 09/12/25 17:33, Harikrishna Shenoy wrote:
> With the DRM_BRIDGE_ATTACH_NO_CONNECTOR framework, the connector is
> no longer initialized in bridge_attach() when the display controller
> sets the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag.
> This causes a null pointer dereference in cdns_mhdp_modeset_retry_fn()
> when trying to access &conn->dev->mode_config.mutex.
> Observed on a board where EDID read failed.
> (log: https://gist.github.com/Jayesh2000/233f87f9becdf1e66f1da6fd53f77429)
>
> Patch 1 adds a connector_ptr which takes care of both
> DRM_BRIDGE_ATTACH_NO_CONNECTOR and !DRM_BRIDGE_ATTACH_NO_CONNECTOR
> case by setting the pointer in appropriate hooks and checking for pointer
> validity before accessing the connector.
> Patch 2 adds mode validation hook to bridge fucntions.
> Patch 3 fixes HDCP to work with both DRM_BRIDGE_ATTACH_NO_CONNECTOR
> and !DRM_BRIDGE_ATTACH_NO_CONNECTOR case by moving HDCP state handling
> into the bridge atomic check inline with the
> DRM_BRIDGE_ATTACH_NO_CONNECTOR model.
> Patches 4,5 do necessary cleanup and alignment for using
> connector pointer.
>
> The rationale behind the sequence of commits is we can cleanly
> switch to drm_connector pointer after removal of connector helper
> code blocks, which are anyways not touch after
> DRM_BRIDGE_ATTACH_NO_CONNECTOR has been enabled in driver.
>
> The last patch make smaller adjustment: lowering the log level for
> noisy DPCD transfer errors.
A gentle ping for this series. This has received multiple R/Bs.
Please help with a review/merge of this series.
Thanks,
Beleswar
[...]
next prev parent reply other threads:[~2026-02-18 9:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 12:03 Harikrishna Shenoy
2025-12-09 12:03 ` [PATCH v10 1/6] drm/bridge: cadence: cdns-mhdp8546-core: Set the mhdp connector earlier in atomic_enable() Harikrishna Shenoy
2025-12-22 12:54 ` Tomi Valkeinen
2026-03-09 17:55 ` Luca Ceresoli
2025-12-09 12:03 ` [PATCH v10 2/6] drm/bridge: cadence: cdns-mhdp8546-core: Add mode_valid hook to drm_bridge_funcs Harikrishna Shenoy
2026-03-09 17:55 ` Luca Ceresoli
2025-12-09 12:03 ` [PATCH v10 3/6] drm/bridge: cadence: cdns-mhdp8546-core: Handle HDCP state in bridge atomic check Harikrishna Shenoy
2025-12-22 12:56 ` Tomi Valkeinen
2026-03-09 17:55 ` Luca Ceresoli
2025-12-09 12:03 ` [PATCH v10 4/6] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge Harikrishna Shenoy
2025-12-22 12:57 ` Tomi Valkeinen
2026-03-09 17:55 ` Luca Ceresoli
2025-12-09 12:03 ` [PATCH v10 5/6] cadence: cdns-mhdp8546*: Change drm_connector from structure to pointer Harikrishna Shenoy
2025-12-22 13:02 ` Tomi Valkeinen
2026-03-09 17:55 ` Luca Ceresoli
2025-12-09 12:03 ` [PATCH v10 6/6] drm/bridge: cadence: cdns-mhdp8546-core: Reduce log level for DPCD read/write Harikrishna Shenoy
2026-03-09 17:55 ` Luca Ceresoli
2026-02-18 9:34 ` Beleswar Prasad Padhi [this message]
2026-03-09 18:08 ` [PATCH v10 0/6] MHDP8546 fixes related to DRM_BRIDGE_ATTACH_NO_CONNECTOR usecase Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cff8c928-9dab-49aa-942d-745d8b0fa75a@ti.com \
--to=b-padhi@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=aradhya.bhatia@linux.dev \
--cc=devarsht@ti.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=h-shenoy@ti.com \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=luca.ceresoli@bootlin.com \
--cc=lumag@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mordan@ispras.ru \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=s-jain1@ti.com \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®