mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: chao@kernel.org, Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to migrate all curseg types during free_segment_range
Date: Wed, 19 Aug 2026 09:56:02 +0800	[thread overview]
Message-ID: <cff8d49a-ef21-415e-984f-ffe57d824da9@kernel.org> (raw)
In-Reply-To: <20260818170018.3132110-1-daeho43@gmail.com>

On 8/19/26 01:00, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
> 
> In free_segment_range(), the curseg evacuation loop only iterates up to
> NR_CURSEG_PERSIST_TYPE (0..5), missing non-persistent in-memory curseg
> types such as CURSEG_COLD_DATA_PINNED and CURSEG_ALL_DATA_ATGC.
> 
> Even though these in-memory curseg types are not saved in the on-disk
> checkpoint header, they still occupy active physical segments at runtime.
> If an active in-memory curseg happens to be allocated within the segment
> range being truncated during filesystem shrink, failing to evacuate it
> will cause subsequent writes to the curseg attempting out-of-bounds I/O
> on the truncated storage range.
> 
> Fix this by expanding the curseg evacuation loop upper bound to
> NR_CURSEG_TYPE to ensure all active curseg types are safely migrated
> out of the target range.
> 

Need fixes and Cc stable line.

> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> Signed-off-by: Sunmin Jeong <s_min.jeong@samsung.com>
> ---
>  fs/f2fs/gc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index ffaa7ba76a1b..192b16ac02f8 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -2222,7 +2222,7 @@ static int free_segment_range(struct f2fs_sb_info *sbi,
>  	mutex_unlock(&DIRTY_I(sbi)->seglist_lock);
>  
>  	/* Move out cursegs from the target range */
> -	for (type = CURSEG_HOT_DATA; type < NR_CURSEG_PERSIST_TYPE; type++) {
> +	for (type = CURSEG_HOT_DATA; type < NR_CURSEG_TYPE; type++) {
>  		err = f2fs_allocate_segment_for_resize(sbi, type, start, end);
>  		if (err)
>  			goto out;


  reply	other threads:[~2026-08-19  1:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 17:00 Daeho Jeong
2026-08-19  1:56 ` Chao Yu [this message]
2026-08-19 18:06 Daeho Jeong
2026-08-20 23:50 ` [f2fs-dev] " Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cff8d49a-ef21-415e-984f-ffe57d824da9@kernel.org \
    --to=chao@kernel.org \
    --cc=daeho43@gmail.com \
    --cc=daehojeong@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®