From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: use generic node names
Date: Sat, 3 Dec 2022 17:15:59 +0100 [thread overview]
Message-ID: <cffb7424-7fad-da98-94ca-2f30802633cb@linaro.org> (raw)
In-Reply-To: <20221203161443.97656-1-krzysztof.kozlowski@linaro.org>
On 3.12.2022 17:14, Krzysztof Kozlowski wrote:
> According to Devicetree specification, the node names should be somewhat
> generic. Use "amplifier" for max98360a and "-regulator" for fixed
> regulators.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi | 8 ++++----
> arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi | 6 +++---
> .../arm64/boot/dts/qcom/sc7180-trogdor-parade-ps8640.dtsi | 2 +-
> .../arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi | 6 +++---
> 5 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
> index 70e52fdb606a..d3cf64c16dcd 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
> @@ -10,22 +10,22 @@
> / {
> /* BOARD-SPECIFIC TOP LEVEL NODES */
>
> - max98360a_1: max98360a_1 {
> + max98360a_1: amplifier-1 {
> compatible = "maxim,max98360a";
> #sound-dai-cells = <0>;
> };
>
> - max98360a_2: max98360a_2 {
> + max98360a_2: amplifier-2 {
> compatible = "maxim,max98360a";
> #sound-dai-cells = <0>;
> };
>
> - max98360a_3: max98360a_3 {
> + max98360a_3: amplifier-3 {
> compatible = "maxim,max98360a";
> #sound-dai-cells = <0>;
> };
>
> - pp3300_touch: pp3300-touch {
> + pp3300_touch: pp3300-touch-regulator {
> compatible = "regulator-fixed";
> regulator-name = "pp3300_touch";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi
> index 5e563655baec..ed12ee35f06b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi
> @@ -13,7 +13,7 @@
> /delete-node/ &usb_c1;
>
> / {
> - avdd_lcd: avdd-lcd {
> + avdd_lcd: avdd-lcd-regulator {
> compatible = "regulator-fixed";
> regulator-name = "avdd_lcd";
>
> @@ -25,7 +25,7 @@ avdd_lcd: avdd-lcd {
> vin-supply = <&pp5000_a>;
> };
>
> - avee_lcd: avee-lcd {
> + avee_lcd: avee-lcd-regulator {
> compatible = "regulator-fixed";
> regulator-name = "avee_lcd";
>
> @@ -37,7 +37,7 @@ avee_lcd: avee-lcd {
> vin-supply = <&pp5000_a>;
> };
>
> - v1p8_mipi: v1p8-mipi {
> + v1p8_mipi: v1p8-mipi-regulator {
> compatible = "regulator-fixed";
> regulator-name = "v1p8_mipi";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-parade-ps8640.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-parade-ps8640.dtsi
> index 070b3acb7baa..ebd6765e2afa 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-parade-ps8640.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-parade-ps8640.dtsi
> @@ -8,7 +8,7 @@
> #include <dt-bindings/gpio/gpio.h>
>
> / {
> - pp3300_brij_ps8640: pp3300-brij-ps8640 {
> + pp3300_brij_ps8640: pp3300-brij-ps8640-regulator {
> compatible = "regulator-fixed";
> status = "okay";
> regulator-name = "pp3300_brij_ps8640";
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi
> index c1367999eafb..cb41ccdaccfd 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi
> @@ -13,7 +13,7 @@
> /delete-node/ &usb_c1;
>
> / {
> - ppvar_lcd: ppvar-lcd {
> + ppvar_lcd: ppvar-lcd-regulator {
> compatible = "regulator-fixed";
> regulator-name = "ppvar_lcd";
>
> @@ -25,7 +25,7 @@ ppvar_lcd: ppvar-lcd {
> vin-supply = <&pp5000_a>;
> };
>
> - v1p8_disp: v1p8-disp {
> + v1p8_disp: v1p8-disp-regulator {
> compatible = "regulator-fixed";
> regulator-name = "v1p8_disp";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
> index 123989ba97e1..9832e752da35 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
> @@ -10,7 +10,7 @@
> #include "sc7180-trogdor.dtsi"
>
> / {
> - avdd_lcd: avdd-lcd {
> + avdd_lcd: avdd-lcd-regulator {
> compatible = "regulator-fixed";
> regulator-name = "avdd_lcd";
>
> @@ -22,7 +22,7 @@ avdd_lcd: avdd-lcd {
> vin-supply = <&pp5000_a>;
> };
>
> - avee_lcd: avee-lcd {
> + avee_lcd: avee-lcd-regulator {
> compatible = "regulator-fixed";
> regulator-name = "avee_lcd";
>
> @@ -35,7 +35,7 @@ avee_lcd: avee-lcd {
> };
>
> pp1800_ts:
> - v1p8_mipi: v1p8-mipi {
> + v1p8_mipi: v1p8-mipi-regulator {
> compatible = "regulator-fixed";
> regulator-name = "v1p8_mipi";
>
next prev parent reply other threads:[~2022-12-03 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 16:14 Krzysztof Kozlowski
2022-12-03 16:15 ` Konrad Dybcio [this message]
2022-12-06 18:19 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cffb7424-7fad-da98-94ca-2f30802633cb@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®