From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944139AbdEZQbv (ORCPT ); Fri, 26 May 2017 12:31:51 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:55997 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbdEZQbt (ORCPT ); Fri, 26 May 2017 12:31:49 -0400 Subject: Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface To: Evgeniy Polyakov , Greg Kroah-Hartman CC: Sebastian Reichel , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20170516200814.12360-1-afd@ti.com> <20170516200814.12360-2-afd@ti.com> <20170525130056.GB30447@kroah.com> <1399ebdb-337e-43b7-9e4d-a0c088bc8c7b@ti.com> <1499591495717767@web38g.yandex.ru> <299fe87d-d0fd-6f16-2f7e-ba56096e5021@ti.com> <1604131495718924@web38g.yandex.ru> <3947221495815182@web23o.yandex.ru> From: "Andrew F. Davis" Message-ID: Date: Fri, 26 May 2017 11:31:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <3947221495815182@web23o.yandex.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/26/2017 11:13 AM, Evgeniy Polyakov wrote: > > > 25.05.2017, 16:50, "Andrew F. Davis" : > >>> Why do you have to create a pseudo-platform device driver to connect w1 and power/supply? >>> >>> I'm not against creating w1 drivers in different places than drivers/w1, but so far >>> it was only power drivers which have problem with it (and they easily work it out), >>> and this rises a flag. >> >> We could keep it in w1 if we really wanted, but then things like Kconfig >> will get difficult to manage (we will jump between menus and have odd >> dependencies). > > One still has to jump between kconfig menus to enable w1 and power devices, > or to use 'select', nothing really changes. > Well, one less step in that we get to drop the platform shim driver, but I see what you mean. >> The other w1/slaves seem to mostly be simple EEPROMs and Gauges that >> would otherwise end up in misc/ so it is fine if they live in w1, but >> BQ27xxx does have a proper home in power/supplies and its i2c interface >> is already there, so moving the w1 interface there also makes sense to me. >> >>> I would rather move w1 header into include/linux, will it be enough? >> >> That's what this patch does, we just also re-organize things a bit so >> only things that need to be public end up in include/linux. It seems to >> be all that is needed for my use-case at least. > > Ok, lets merge it. Great, thanks! > > My personal note: please drop TI copyright from headers, at least from those which already exist > and you move them around, it is your work and not TI. It is up to you to put into driver itself. > 9-5 TI owns everything I touch :) so I just figured I should add it, but I have no personal problem dropping the copyright notice (actually I already did this as you requested this in v1).