mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Stecklina <jsteckli@amazon.de>
To: Baoquan He <bhe@redhat.com>
Cc: Julian Stecklina <js@alien8.de>, <x86@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	<hpa@zytor.com>, <linux-kernel@vger.kernel.org>,
	<jschoenh@amazon.de>
Subject: Re: [PATCH 1/2] x86/boot: fix KASL when memmap range manipulation is used
Date: Mon, 11 Feb 2019 10:54:39 +0100	[thread overview]
Message-ID: <ciirm8zhr2ira8.fsf@u54ee758033e858cfa736.ant.amazon.com> (raw)
In-Reply-To: <20190211090931.GA2501@localhost> (Baoquan He's message of "Mon, 11 Feb 2019 17:09:31 +0800")

Baoquan He <bhe@redhat.com> writes:

> On 01/30/19 at 05:40pm, Julian Stecklina wrote:
>> diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
>> index 9ed9709..5657e34 100644
>> --- a/arch/x86/boot/compressed/kaslr.c
>> +++ b/arch/x86/boot/compressed/kaslr.c
>> @@ -155,6 +155,12 @@ parse_memmap(char *p, unsigned long long *start, unsigned long long *size)
>>  	case '#':
>>  	case '$':
>>  	case '!':
>> +		/*
>> +		 * % would need some more complex parsing, because regions might
>> +		 * actually become usable for KASLR, but the simple way of
>> +		 * ignoring anything that is mentioned in % works for now.
>> +		 */
>
> This seems to make thing more complicated even though have to. One
> concern is whether we need to check the oldtype|newtype , e.g
> oldtype=reserverd, newtype=RAM, is it possible to set like that?

With the above patch the boot code will avoid using any region targeted
by % for KASLR. This does mean regions that are changed to be usable via
% are not taken into account.

Julian

      reply	other threads:[~2019-02-11  9:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30 16:40 Julian Stecklina
2019-01-30 16:40 ` [PATCH 2/2] x86/boot: increase maximum number of avoided KASLR regions Julian Stecklina
2019-02-05 14:44   ` Borislav Petkov
2019-02-06 12:50     ` Julian Stecklina
2019-02-06 14:17       ` Borislav Petkov
2019-02-06 15:29         ` Kees Cook
2019-02-06 17:53           ` Borislav Petkov
2019-02-11  9:09 ` [PATCH 1/2] x86/boot: fix KASL when memmap range manipulation is used Baoquan He
2019-02-11  9:54   ` Julian Stecklina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ciirm8zhr2ira8.fsf@u54ee758033e858cfa736.ant.amazon.com \
    --to=jsteckli@amazon.de \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=js@alien8.de \
    --cc=jschoenh@amazon.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®