From: Con Kolivas <kernel@kolivas.org>
To: Peter Williams <pwil3058@bigpond.net.au>
Cc: linux list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
ck list <ck@vds.kolivas.org>
Subject: Re: [PATCH][3/4] sched: add above background load function
Date: Tue, 14 Mar 2006 10:38:25 +1100 [thread overview]
Message-ID: <cone.1142293105.216069.5853.501@kolivas.org> (raw)
In-Reply-To: <4415FCBA.7030100@bigpond.net.au>
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
Peter Williams writes:
> Con Kolivas wrote:
>> + if (weighted_cpuload(cpu) >= SCHED_LOAD_SCALE)
>> + return 1;
> I think that you may need to take into account the contribution to the
> load by your swap prefetching thread when it calls this function
> otherwise it could cause an incorrect (from your point of view) positive
> return value. If the thread has a positive nice value this comment can
> probably be ignored.
kprefetchd runs at nice 19.
Cheers,
Con
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2006-03-13 23:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-13 8:07 Con Kolivas
2006-03-13 9:07 ` Ingo Molnar
2006-03-13 23:14 ` Peter Williams
2006-03-13 23:38 ` Con Kolivas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cone.1142293105.216069.5853.501@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pwil3058@bigpond.net.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®