mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Con Kolivas <kernel@kolivas.org>
To: tim.c.chen@linux.intel.com
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: Regression seen for patch "sched:dont decrease idle sleep avg"
Date: Tue, 09 May 2006 10:43:09 +1000	[thread overview]
Message-ID: <cone.1147135389.188411.32203.501@kolivas.org> (raw)
In-Reply-To: <1147130298.30649.33.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

Tim Chen writes:

> Con,
> 
> As a result of the patch "sched:dont decrease idle sleep avg" 
> introduced after 2.6.15, there is a 4% drop in Volanomark 
> throughput on our Itanium test machine.  
> Probably the following happened:
> Compared to previous code, this patch slightly increases 
> the the priority boost when a job is woken up.
> This adds priority spread and variations to the wait time of jobs
> on run queue if we have a lot of similar jobs in the system.
> 
> See patch:
> http://www.kernel.org/git/?
> p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e72ff0bb2c163eb13014ba113701bd42dab382fe 

Lovely

This patch corrects a bug in the original code which unintentionally dropped 
the priority of tasks that were idle but were already high priority on other 
merits. It doesn't further increase the priority. The 4% almost certainly is 
due to the lack of any locking in the threading model used by the java 
virtual machine on volanomark and it being pure luck that penalising 
particularly idle tasks previously improved the wakeup timing of basically 
yielding dependant threads. This patch did fix bugs related to interactive 
yet idle tasks like consoles misbehaving. The fact that the presence of that 
particular bug improved a multithreaded benchmark that uses such a threading 
model is pure chance and (obviously) not design. I wouldn't like to see this 
bug reintroduced on the basis of this benchmark result.

---
-ck


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2006-05-09  0:43 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-08 23:18 Tim Chen
2006-05-09  0:43 ` Con Kolivas [this message]
2006-05-09  1:07   ` Martin Bligh
2006-05-12  0:04   ` Chen, Kenneth W
2006-05-13 12:27     ` Andrew Morton
2006-05-13 13:07       ` Mike Galbraith
2006-05-14 16:03     ` Con Kolivas
2006-05-15 19:01       ` Chen, Kenneth W
2006-05-15 23:45         ` Con Kolivas
2006-05-16  1:22           ` Chen, Kenneth W
2006-05-16  1:44             ` Con Kolivas
2006-05-16  4:10           ` Mike Galbraith
2006-05-16 23:32           ` Tim Chen
2006-05-17  4:25             ` Mike Galbraith
2006-05-17  4:45               ` Peter Williams
2006-05-17  5:24                 ` Mike Galbraith
2006-05-17  8:23             ` Con Kolivas
2006-05-17  9:49               ` Mike Galbraith
2006-05-17 10:25                 ` Con Kolivas
2006-05-17 11:42                   ` Mike Galbraith
2006-05-17 12:46                     ` Con Kolivas
2006-05-17 13:41                       ` Mike Galbraith
2006-05-17 15:10                         ` Con Kolivas
2006-05-17 17:21                           ` Ray Lee
2006-05-17 19:33               ` Chen, Kenneth W
2006-05-18  0:35                 ` Con Kolivas
2006-05-18  1:10                   ` Chen, Kenneth W
2006-05-18  1:38                     ` Con Kolivas
2006-05-18  5:44                       ` Mike Galbraith
2006-05-18  5:52                         ` Con Kolivas
2006-05-18  7:04                           ` Mike Galbraith
2006-05-18 12:59                             ` Mike Galbraith
2006-05-19  1:10                               ` Con Kolivas
2006-05-18 23:17                           ` Chen, Kenneth W
2006-05-19  1:30                             ` [PATCH] sched: fix interactive ceiling code Con Kolivas
2006-05-19  2:02                               ` Mike Galbraith
2006-05-19  9:40                               ` Ingo Molnar
2006-05-19 14:37                               ` Chen, Kenneth W
2006-05-19 16:19                                 ` tim_c_chen
2006-05-18 23:34                           ` Regression seen for patch "sched:dont decrease idle sleep avg" Chen, Kenneth W
2006-05-19  1:07                             ` Con Kolivas
2006-05-16  4:07         ` Mike Galbraith
2006-05-18  4:01 Al Boldi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cone.1147135389.188411.32203.501@kolivas.org \
    --to=kernel@kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®