From: Peter Feuerer <peter@piie.net>
To: Borislav Petkov <bp@alien8.de>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <petkovbb@gmail.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] acerhdf: make needlessly global symbols static
Date: Sat, 10 Jul 2010 19:42:51 +0200 [thread overview]
Message-ID: <cone.1278783771.875800.3926.1000@deskpiie> (raw)
In-Reply-To: <20100708090836.GA14580@a1.tnic>
Borislav Petkov writes:
> From: Axel Lin <axel.lin@gmail.com>
> Date: Thu, Jul 08, 2010 at 09:46:20AM +0800
>
>> The following symbols are needlessly defined global:
>>
>> thz_dev
>> cl_dev
>> acerhdf_dev
>> acerhdf_dev_ops
>> acerhdf_cooling_ops
>>
>> This patch makes the symbols static.
>>
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Borislav Petkov <bp@alien8.de>
Acked-by: Peter Feuerer <peter@piie.net>
>
>> ---
>> drivers/platform/x86/acerhdf.c | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
>> index 7b2384d..5caaaf0 100644
>> --- a/drivers/platform/x86/acerhdf.c
>> +++ b/drivers/platform/x86/acerhdf.c
>> @@ -92,9 +92,9 @@ static unsigned int fanstate = ACERHDF_FAN_AUTO;
>> static char force_bios[16];
>> static char force_product[16];
>> static unsigned int prev_interval;
>> -struct thermal_zone_device *thz_dev;
>> -struct thermal_cooling_device *cl_dev;
>> -struct platform_device *acerhdf_dev;
>> +static struct thermal_zone_device *thz_dev;
>> +static struct thermal_cooling_device *cl_dev;
>> +static struct platform_device *acerhdf_dev;
>>
>> module_param(kernelmode, uint, 0);
>> MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off");
>> @@ -374,7 +374,7 @@ static int acerhdf_get_crit_temp(struct thermal_zone_device *thermal,
>> }
>>
>> /* bind callback functions to thermalzone */
>> -struct thermal_zone_device_ops acerhdf_dev_ops = {
>> +static struct thermal_zone_device_ops acerhdf_dev_ops = {
>> .bind = acerhdf_bind,
>> .unbind = acerhdf_unbind,
>> .get_temp = acerhdf_get_ec_temp,
>> @@ -449,7 +449,7 @@ err_out:
>> }
>>
>> /* bind fan callbacks to fan device */
>> -struct thermal_cooling_device_ops acerhdf_cooling_ops = {
>> +static struct thermal_cooling_device_ops acerhdf_cooling_ops = {
>> .get_max_state = acerhdf_get_max_state,
>> .get_cur_state = acerhdf_get_cur_state,
>> .set_cur_state = acerhdf_set_cur_state,
>> --
>> 1.5.4.3
>>
>>
>>
thanks and kind regards,
--peter;
prev parent reply other threads:[~2010-07-10 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 1:46 Axel Lin
2010-07-08 9:08 ` Borislav Petkov
2010-07-10 17:42 ` Peter Feuerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cone.1278783771.875800.3926.1000@deskpiie \
--to=peter@piie.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=petkovbb@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®