From: Peter Feuerer <peter@piie.net>
To: "Anton V. Boyarshinov" <boyarsh@altlinux.org>
Cc: Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acerhdf.c: spaces in aliased changed to *
Date: Fri, 29 Jul 2011 23:55:58 +0200 [thread overview]
Message-ID: <cone.1311976558.82572.3703.1000@deskpiie> (raw)
In-Reply-To: <20110728180535.51dce58d@boyarsh.office.altlinux.ru>
Hi,
Matthew, please apply, thanks.
Anton V. Boyarshinov writes:
> It seems that aliases shouldn't contain spaces, as
> module-init-tools uses them as delimeters in module.alias file
>
> Signed-off-by: Anton V. Boyarshinov <boyarsh@altlinux.org>
Acked-by: Peter Feuerer <peter@piie.net>
> ---
> drivers/platform/x86/acerhdf.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index fca3489..7a8568b 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -703,15 +703,15 @@ MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Peter Feuerer");
> MODULE_DESCRIPTION("Aspire One temperature and fan driver");
> MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
> -MODULE_ALIAS("dmi:*:*Acer*:pnAspire 1410*:");
> -MODULE_ALIAS("dmi:*:*Acer*:pnAspire 1810*:");
> +MODULE_ALIAS("dmi:*:*Acer*:pnAspire*1410*:");
> +MODULE_ALIAS("dmi:*:*Acer*:pnAspire*1810*:");
> MODULE_ALIAS("dmi:*:*Acer*:pnAO531*:");
> MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
> MODULE_ALIAS("dmi:*:*Gateway*:pnLT31*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOTMU*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOTMA*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnAOA*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOA*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOTMU*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOTMA*:");
>
> module_init(acerhdf_init);
> module_exit(acerhdf_exit);
> --
> 1.7.2.2
>
next prev parent reply other threads:[~2011-07-29 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 14:05 Anton V. Boyarshinov
2011-07-29 21:55 ` Peter Feuerer [this message]
2011-08-05 19:22 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cone.1311976558.82572.3703.1000@deskpiie \
--to=peter@piie.net \
--cc=boyarsh@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®