mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Feuerer <peter@piie.net>
To: Joe Perches <joe@perches.com>
Cc: Matthew Garrett <mjg@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] acerhdf: Message logging neatening
Date: Mon, 12 Dec 2011 19:26:50 +0100	[thread overview]
Message-ID: <cone.1323714410.432860.1894.1000@zopiie> (raw)
In-Reply-To: <96a258354ce375bf80259f783506bbd7191b520d.1322593277.git.joe@perches.com>

Hi Joe,

thanks for sending this patch, I've got some comments on it.


Joe Perches writes:
> Use pr_warn not pr_warning.

Don't see any line, where you changed this…


> Coalesce formats.
> Argument aligning.
> Remove superfluous parentheses.

Discussed inline.


> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/platform/x86/acerhdf.c |   19 ++++++++-----------
>  1 files changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 833c0ec..639db4d 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -262,12 +262,11 @@ static void acerhdf_change_fanstate(int state)
>  	unsigned char cmd;
>  
>  	if (verbose)
> -		pr_notice("fan %s\n", (state == ACERHDF_FAN_OFF) ?
> -				"OFF" : "ON");
> +		pr_notice("fan %s\n", state == ACERHDF_FAN_OFF ? "OFF" : "ON");

In my opinion the one with brackets is easier to read.


>  	if ((state != ACERHDF_FAN_OFF) && (state != ACERHDF_FAN_AUTO)) {
>  		pr_err("invalid fan state %d requested, setting to auto!\n",
> -			state);
> +		       state);

Is it written somewhere to use spaces instead of a tab in such cases? I like 
tab more. (1)


>  		state = ACERHDF_FAN_AUTO;
>  	}
>  
> @@ -282,19 +281,18 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
>  {
>  	if (fanon > ACERHDF_MAX_FANON) {
>  		pr_err("fanon temperature too high, set to %d\n",
> -				ACERHDF_MAX_FANON);
> +		       ACERHDF_MAX_FANON);

see (1). - but maybe one tab shall be removed.


>  		fanon = ACERHDF_MAX_FANON;
>  	}
>  
>  	if (kernelmode && prev_interval != interval) {
>  		if (interval > ACERHDF_MAX_INTERVAL) {
>  			pr_err("interval too high, set to %d\n",
> -				ACERHDF_MAX_INTERVAL);
> +			       ACERHDF_MAX_INTERVAL);

see (1).


>  			interval = ACERHDF_MAX_INTERVAL;
>  		}
>  		if (verbose)
> -			pr_notice("interval changed to: %d\n",
> -					interval);
> +			pr_notice("interval changed to: %d\n", interval);

I agree on this.


>  		thermal->polling_delay = interval*1000;
>  		prev_interval = interval;
>  	}
> @@ -605,8 +603,8 @@ static int acerhdf_check_hardware(void)
>  	}
>  
>  	if (!bios_cfg) {
> -		pr_err("unknown (unsupported) BIOS version %s/%s/%s, "
> -			"please report, aborting!\n", vendor, product, version);
> +		pr_err("unknown (unsupported) BIOS version %s/%s/%s, please report, aborting!\n",
> +		       vendor, product, version);

disagree, as it exceeds 80 chars.


>  		return -EINVAL;
>  	}
>  
> @@ -616,8 +614,7 @@ static int acerhdf_check_hardware(void)
>  	 */
>  	if (!kernelmode) {
>  		pr_notice("Fan control off, to enable do:\n");
> -		pr_notice("echo -n \"enabled\" > "
> -			"/sys/class/thermal/thermal_zone0/mode\n");
> +		pr_notice("echo -n \"enabled\" > /sys/class/thermal/thermal_zone0/mode\n");

disagree, as it exceeds 80 chars when using tabstop=8.


>  	}
>  
>  	return 0;
> -- 
> 1.7.6.405.gc1be0
> 

--
kind regards,
--peter;

  reply	other threads:[~2011-12-12 18:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 19:04 [PATCH 1/2] acer-wmi: " Joe Perches
2011-11-29 19:04 ` [PATCH 2/2] acerhdf: " Joe Perches
2011-12-12 18:26   ` Peter Feuerer [this message]
2011-12-12 18:56     ` Joe Perches
2011-12-05  3:57 ` [PATCH 1/2] acer-wmi: " joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cone.1323714410.432860.1894.1000@zopiie \
    --to=peter@piie.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®