From: "Pekka J Enberg" <penberg@cs.helsinki.fi>
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Cc: davem@davemloft.net, netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: net: generic netdev_ioaddr
Date: Fri, 29 Oct 2004 21:50:20 +0300 [thread overview]
Message-ID: <courier.418290EC.00002E85@courier.cs.helsinki.fi> (raw)
In-Reply-To: <20041029131607.GU24336@parcelfarce.linux.theplanet.co.uk>
Hi,
Al Viro writes:
> NAK. ->base_addr casting is a Bad Idea(tm) and natsemi "solution" isn't
> (thanks for spotting that crap in natsemi, though; will fix...)
>
> Note that there is no such thing as "generic IO base address" - it _is_
> private and in the best case current ->base_addr is a scratch register
> probably used for something vaguely connected with some IO, but it's
> really up to driver...
Yup, I thought about that after I sent the patch. However, as it stands now,
many network drivers use netdev->base_addr for just that. Perhaps it should
be nuked completely instead?
Pekka
next prev parent reply other threads:[~2004-10-30 1:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 10:04 [RFC][PATCH 0/3] " Pekka Enberg
2004-10-29 10:04 ` [PATCH 1/3] " Pekka Enberg
2004-10-29 10:05 ` [PATCH 2/3] net: use netdev_ioaddr in natsemi Pekka Enberg
2004-10-29 10:05 ` [PATCH 3/3] net: use netdev_ioaddr in 8139too Pekka Enberg
2004-10-29 11:52 ` [RFC][PATCH 0/3] net: generic netdev_ioaddr Christoph Hellwig
2004-10-29 13:16 ` Al Viro
2004-10-29 18:50 ` Pekka J Enberg [this message]
2004-10-29 19:18 ` Krzysztof Halasa
2004-10-29 19:38 ` Al Viro
2004-10-29 21:13 ` Krzysztof Halasa
2004-10-30 9:52 ` Pekka Enberg
2004-10-31 1:02 ` Krzysztof Halasa
2004-10-31 7:11 ` Pekka Enberg
2004-10-31 23:14 ` Krzysztof Halasa
2004-11-01 14:27 ` Pekka Enberg
2004-10-29 20:01 ` [PATCH] net: fix natsemi base_addr casting Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=courier.418290EC.00002E85@courier.cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®