mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Malcolm Rowe <malcolm-linux@farside.org.uk>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Symlink /sys/class/block to /sys/block (fwd)
Date: Wed, 23 Feb 2005 09:47:44 +0000	[thread overview]
Message-ID: <courier.421C5140.00003F05@mail.farside.org.uk> (raw)

Greg KH writes: 

>> Following the discussion in [1], the attached patch creates /sys/class/block
>> as a symlink to /sys/block. The patch applies to 2.6.11-rc4-bk7.   
>> 
>> Please cc: me on any replies - I'm not subscribed to the mailing list. 
> Hm, your patch is linewrapped, and can't be applied :(

Bah, and I did send it to myself first, but I guess my mailer un-flowed it 
for me :-(.  I'll try to find a better mailer. 

> But more importantly:
>> static void disk_release(struct kobject * kobj)
> 
> Did you try to remove a disk (like a usb device) and see what happens
> here?  Hint, this isn't the proper place to remove the symlink...

Er, yeah. Oops. 

*Is* there a sensible place to remove the symlink from, though?  Nobody 
seems to call subsystem_unregister(&block_subsys), which is the place I'd 
expect to add a call to, and I can't see anything that's otherwise 
obvious... 

Regards,
Malcolm 

[resent using the right address for linux-kernel. Sorry for the duplicate, 
Greg]

                 reply	other threads:[~2005-02-23  9:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=courier.421C5140.00003F05@mail.farside.org.uk \
    --to=malcolm-linux@farside.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®