From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262267AbVGKGhF (ORCPT ); Mon, 11 Jul 2005 02:37:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262265AbVGKGhF (ORCPT ); Mon, 11 Jul 2005 02:37:05 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:14036 "EHLO mail.cs.helsinki.fi") by vger.kernel.org with ESMTP id S262263AbVGKGhC (ORCPT ); Mon, 11 Jul 2005 02:37:02 -0400 References: <1120851221.9655.17.camel@localhost> <1121019702.20821.17.camel@localhost> In-Reply-To: From: "Pekka J Enberg" To: Roman Zippel Cc: Bryan Henderson , Andrew Morton , bfields@fieldses.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linuxram@us.ibm.com, mike@waychison.com, Miklos Szeredi , Alexander Viro , Vojtech Pavlik Subject: Re: share/private/slave a subtree - define vs enum Date: Mon, 11 Jul 2005 09:37:01 +0300 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="utf-8,iso-8859-1" Content-Transfer-Encoding: 7bit Message-ID: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Roman, Roman Zippel writes: > I don't generally disagree with that, I just think that defines are not > part of that list. They're in Documentation/CodingStyle (see Chapter 11). Roman Zippel writes: > Look, it's great that you do reviews, but please keep in mind it's the > author who has to work with code and he has to be primarily happy with, > so you don't have to point out every minor issue. I completely agree with you that the author must be happy with the code. I also think Vojtech has a good point about reviewing for the most important things first and worrying about nitpicks later. I'll try to find a better balance for reviews. Thanks Roman. Pekka