From: Kirill Smelkov <kirr@mns.spb.ru>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>,
matt mooney <mfm@muteddisk.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-uvc-devel@lists.berlios.de,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Kirill Smelkov <kirr@mns.spb.ru>
Subject: [PATCH v4 0/2] USB: EHCI: Allow users to override 80% max periodic bandwidth
Date: Sun, 3 Jul 2011 20:36:55 +0400 [thread overview]
Message-ID: <cover.1309710420.git.kirr@mns.spb.ru> (raw)
There are cases, when 80% max isochronous bandwidth is too limiting.
Let's allow knowledgeable users to override that 80% max limit explicitly for
extreme cases, like 2 high bandwidth isochronously streaming devices on the
same High Speed USB bus in order to make them work simultaneously.
See full details in PATCH 2/2.
Changes since v3:
- as suggested by Greg KH added new entry to Documentation/ABI/;
- for consistency also touched Documentation/usb/ehci.txt reminding we now
have new setting for periodic transfers scheduler.
The base text in-there requires much updating regarding isochronous
transfers, so only "TBD" with brief description was put because I'm not the best
person to get EHCI description into shape;
- added ACK to PATCH 2/2 from Alan Stern based on previous feedback. (I hope
it's still semi-ok to put it, inspite of adding new not-reviewed text into
docs);
- minor cosmetics in patch descriptions.
Changes since v2:
- changed the copyright in ehci-sysfs from David Brownell to Alan Stern;
- added ACK to PATCH 1/2 from Alan Stern;
- inspired by concerns raised by Sarah Sharp, added more details about testing
done on N10 chipset, system stability, and that no-harm-is-done for those,
who do not change uframe_periodic_max from default 100us;
- when decreasing uframe_periodic_max, compare with the maximum number of
microseconds already allocated for any uframe, instead of stopping as soon
as it finds something above the new limit.
Changes since v1:
- dropped RFC status as "this seems like the sort of feature somebody might
reasonably want to use -- if they know exactly what they're doing";
- new preparatory patch (1/2) which moves already-in-there sysfs code into
ehci-sysfs.c;
- moved uframe_periodic_max parameter from module option to sysfs attribute,
so that it can be set per controller and at runtime, added validity checks;
- clarified a bit bandwidth analysis for 96% max periodic setup as noticed by
Alan Stern;
- clarified patch description saying that set in stone 80% max periodic is
specified by USB 2.0;
Kirill Smelkov (2):
USB: EHCI: Move sysfs related bits into ehci-sysfs.c
USB: EHCI: Allow users to override 80% max periodic bandwidth
Documentation/ABI/testing/sysfs-module | 23 ++++
Documentation/usb/ehci.txt | 2 +
drivers/usb/host/ehci-hcd.c | 11 ++-
drivers/usb/host/ehci-hub.c | 75 -------------
drivers/usb/host/ehci-sched.c | 17 +--
drivers/usb/host/ehci-sysfs.c | 190 ++++++++++++++++++++++++++++++++
drivers/usb/host/ehci.h | 2 +
7 files changed, 233 insertions(+), 87 deletions(-)
create mode 100644 drivers/usb/host/ehci-sysfs.c
--
1.7.6.rc3
next reply other threads:[~2011-07-03 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-03 16:36 Kirill Smelkov [this message]
2011-07-03 16:36 ` [PATCH v4 1/2] USB: EHCI: Move sysfs related bits into ehci-sysfs.c Kirill Smelkov
2011-07-03 16:36 ` [PATCH v4 2/2] USB: EHCI: Allow users to override 80% max periodic bandwidth Kirill Smelkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1309710420.git.kirr@mns.spb.ru \
--to=kirr@mns.spb.ru \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-uvc-devel@lists.berlios.de \
--cc=mfm@muteddisk.com \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®