From: Jan Kiszka <jan.kiszka@siemens.com>
To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
"Hans J. Koch" <hjk@hansjkoch.de>,
Greg Kroah-Hartman <gregkh@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
kvm@vger.kernel.org, Brian King <brking@linux.vnet.ibm.com>
Subject: [PATCH 0/3] PCI: Rework config space locking, add INTx masking services
Date: Mon, 12 Sep 2011 18:54:01 +0200 [thread overview]
Message-ID: <cover.1315846441.git.jan.kiszka@siemens.com> (raw)
This series tries to heal the currently broken locking scheme around PCI
config space accesses.
We have an interface lock out access via sysfs, but that service wrongly
assumes it is only called by one instance at a time for some device. So
two loops doing
echo 1 > /sys/bus/pci/devices/<some-device>/reset
in parallel will trigger a kernel BUG at the moment.
Besides synchronizing with user space, we also need to manage config
space access of generic PCI drivers. They need to mask legacy interrupt
lines while the specific driver runs in user space or a guest OS.
The approach taken here is provide mutex-like locking for general
access - which still requires a special mechanism due to requirements of
the IBM Power RAID SCSI driver. Furthermore, INTx masking is now
available via the PCI core and synchronized via the internal pci_lock.
Not sure who may want to take this, so I'm CC'ing broadly.
CC: Brian King <brking@linux.vnet.ibm.com>
Jan Kiszka (3):
pci: Rework config space blocking services
pci: Introduce INTx check & mask API
uio: Convert uio_generic_pci to new intx masking API
drivers/pci/access.c | 76 +++++++++++++++++----------
drivers/pci/iov.c | 12 ++--
drivers/pci/pci.c | 114 ++++++++++++++++++++++++++++++++++++++++-
drivers/pci/pci.h | 2 +
drivers/scsi/ipr.c | 66 +++++++++++++++++++++---
drivers/scsi/ipr.h | 1 +
drivers/uio/uio_pci_generic.c | 82 +++---------------------------
include/linux/pci.h | 17 ++++--
8 files changed, 248 insertions(+), 122 deletions(-)
--
1.7.3.4
next reply other threads:[~2011-09-12 16:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 16:54 Jan Kiszka [this message]
2011-09-12 16:54 ` [PATCH 1/3] pci: Rework config space blocking services Jan Kiszka
2011-11-02 20:59 ` Jesse Barnes
2011-09-12 16:54 ` [PATCH 2/3] pci: Introduce INTx check & mask API Jan Kiszka
2011-09-12 16:54 ` [PATCH 3/3] uio: Convert uio_generic_pci to new intx masking API Jan Kiszka
2011-10-06 15:48 ` [PATCH 0/3] PCI: Rework config space locking, add INTx masking services Jesse Barnes
2011-10-14 14:48 ` Jan Kiszka
2011-10-25 12:32 ` Jan Kiszka
2011-10-14 15:44 ` Brian King
2011-10-16 14:25 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1315846441.git.jan.kiszka@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=brking@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=hjk@hansjkoch.de \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome