mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Moritz König" <moritz.koenig@fau.de>
To: "Ian Abbott" <abbotti@mev.co.uk>,
	"H Hartley Sweeten" <hsweeten@visionengravers.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Colin Cronin" <colinpatrickcronin@gmail.com>,
	"Moritz König" <moritz.koenig@fau.de>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Fabian Lang <fabian.lang@fau.de>, linux-kernel@i4.cs.fau.de
Subject: [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h
Date: Thu, 10 Dec 2015 15:57:40 +0100	[thread overview]
Message-ID: <cover.1449755183.git.moritz.koenig@fau.de> (raw)

This patchset fixes all the warnings and legitimate checks of
checkpatch.pl in comedi.h. 

The following warnings were fixed:
 * WARNING: Block comments use * on subsequent lines
 * WARNING: Block comments use a trailing */ on a separate line
The following checks were fixed:
 * CHECK: spaces preferred around that '<<' (ctx:VxV)
 * CHECK: spaces preferred around that '>>' (ctx:VxV)
 * CHECK: spaces preferred around that '|' (ctx:VxV)

The following checks are not legitimate here and were not fixed:
 * CHECK: spaces preferred around that '&' (ctx:VxV)
	This '&' is not a binary operator, but a referencing.
 * CHECK: Prefer using the BIT macro
	The author defined a BIT macro here.
 * CHECK: Avoid CamelCase: <UNIT_mA>
	This refers to the unit 'milli ampere'.

Moritz König (2):
  staging: COMEDI: Fixed the format of comments
  staging: COMEDI: Added missing spaces at binary operators

 drivers/staging/comedi/comedi.h | 232 +++++++++++++++++++++++-----------------
 1 file changed, 131 insertions(+), 101 deletions(-)

-- 
1.9.1


             reply	other threads:[~2015-12-10 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 14:57 Moritz König [this message]
2015-12-10 14:57 ` [PATCH 1/2] staging: COMEDI: Fixed the format of comments Moritz König
2015-12-10 14:57 ` [PATCH 2/2] staging: COMEDI: Added missing spaces at binary operators Moritz König
2015-12-10 20:22   ` Joe Perches
2015-12-11 10:01 ` [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1449755183.git.moritz.koenig@fau.de \
    --to=moritz.koenig@fau.de \
    --cc=abbotti@mev.co.uk \
    --cc=colinpatrickcronin@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabian.lang@fau.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome