From: Tom Saeger <tom.saeger@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Tom Saeger <tom.saeger@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns
Date: Tue, 31 Oct 2017 09:46:11 -0500 [thread overview]
Message-ID: <cover.1509401037.git.tom.saeger@oracle.com> (raw)
This series attempts to fix all stale MAINTAINER file "F" and "X" patterns.
First patch adds an option "checks" to get_maintainer.pl which outputs
warnings for any "F" or "X" pattern found in MAINTAINER file which does
not register any file/directory matches known by git in current worktree.
Originally, I wrote a standalone script "check_maintainer", but as this
duplicated some of the functions found in get_maintainer.pl it seemed to
make more sense to change get_maintainer.pl directly.
The "-x|--checks" option is intended to be used as follows:
./scripts/get_maintainer.pl -x ./ | tee out.txt
./MAINTAINERS:1743 warning: no matches drivers/.*/pm8...-.* F: drivers/*/pm8???-*
./MAINTAINERS:8721 warning: no matches drivers/net/ethernet/mellanox/mlx5/core/en_ipsec/.* F: drivers/net/ethernet/mellanox/mlx5/core/en_ipsec/*
./MAINTAINERS:8722 warning: no matches drivers/net/ethernet/mellanox/mlx5/core/ipsec.* F: drivers/net/ethernet/mellanox/mlx5/core/ipsec*
./MAINTAINERS:9431 warning: no matches net/core/flow\.c F: net/core/flow.c
The output format lends itself to the following in vim (note tab
character):
set errorformat=%f:%l\ %m
cfile out.txt
copen
Second patch fixes all MAINTAINER warnings but four (those listed above), which were not
obvious to me how to fix. Most fixes were obvious, requiring only "ls
./**/*pat*" or "git log --follow -- xyz.c" or "git blame MAINTAINERS" to
figure out what needed to be changed.
Patches are independent, however I did employ the first in figuring out the
second.
Looking for input on how best to get these merged. Some of these have
been broken for a long time - so stable kernels might benefit from
backporting.
Future enhancements could sanity check all the other entry types found in
MAINTAINER file.
--Tom
Tom Saeger (2):
scripts: warn about invalid MAINTAINER patterns
MAINTAINERS: various pattern fixes for mv/rm/typos
MAINTAINERS | 107 ++++++++++++++++++----------------------------
scripts/get_maintainer.pl | 65 ++++++++++++++++++++++++++++
2 files changed, 107 insertions(+), 65 deletions(-)
--
2.14.3
next reply other threads:[~2017-10-31 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 14:46 Tom Saeger [this message]
2017-10-31 14:46 ` [RFC PATCH 1/2] " Tom Saeger
2017-10-31 15:47 ` Joe Perches
2017-10-31 15:50 ` Tom Saeger
2017-10-31 14:46 ` [RFC PATCH 2/2] MAINTAINERS: various pattern fixes for mv/rm/typos Tom Saeger
2017-10-31 15:55 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1509401037.git.tom.saeger@oracle.com \
--to=tom.saeger@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome