From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711D2C43143 for ; Mon, 1 Oct 2018 16:18:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36A0C2145D for ; Mon, 1 Oct 2018 16:18:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NQZahxs1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36A0C2145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726285AbeJAW5H (ORCPT ); Mon, 1 Oct 2018 18:57:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:52734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725740AbeJAW5G (ORCPT ); Mon, 1 Oct 2018 18:57:06 -0400 Received: from localhost.localdomain (c-98-220-238-81.hsd1.il.comcast.net [98.220.238.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B6392089A; Mon, 1 Oct 2018 16:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1538410713; bh=N2i8Epuc2VyN1oFPXe3N31kKzEBjFb8wOSCCPnZSC7o=; h=From:To:Cc:Subject:Date:From; b=NQZahxs1Vfi/YerhrB8FHAiEQVV06+VtHkKhI7hKFaPGWcoyN0B7tazKnnKRK3K1q ULjgDFnT3gCNDre/lks7R7wDDj1RfKO6wWYQl45n+i21Mv+v94stzlQtvVgTz96Rhe gkTvRaFxp8PObSeMu7Wuwq1sNHna5mEvvgUH40IA= From: Tom Zanussi To: rostedt@goodmis.org Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel@joelfernandes.org, mathieu.desnoyers@efficios.com, julia@ni.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: [PATCH v5 0/8] tracing: Hist trigger snapshot and onchange additions Date: Mon, 1 Oct 2018 11:18:00 -0500 Message-Id: X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Zanussi Hi, This is v5 of the hist trigger snapshot and onchange additions patchset. It's the same as v4, but adds a test case for the new trace syntax as suggested by Masami, and also adds a new test case for the onchange addition. v4->v5 changes: - added 'trace' keyword test case - added 'onchange' handler test case v3->v4 changes: - added 'trace' keyword for generating synthetic events - fix elt_data leak - changed cond_update to cond_update_fn_t v2->v3 changes: - fixed problem where trace actions were only being allowed for onmatch handlers - now trace actions can be used with any handler. - fixed problem where no action was being assigned to onmatch handlers if save or snapshot actions were specified. v1->v2 changes: - added missing tracing_cond_snapshot_data() definition for when CONFIG_TRACER_SNAPSHOT not defined - removed an unnecessary WARN_ON() in track_data_snapshot_print() Original text: This patchset adds some useful new functions to the hist trigger code: a snapshot action and an onchange handler. In order to make it easier to add these and in the process make the code more generic, I separated the code into explicit 'handlers' and 'actions', handlers being things like 'onmax' and 'onchange', and 'actions' being things like 'take a snapshot' or 'save some fields'. The first few patches do that basic refactoring, which make it easier to add the subsequent changes that arbitrarily combine actions and handlers. The fourth patch adds a 'conditional snapshot' capability that via a new tracing_snaphot_cond() function extends the existing snapshot code. It allows the caller to associate some user data with the snapshot that can be checked and saved in an update() callback whose return value determines whether the snapshot should be taken or not. The remaining patches finally add the new snapshot action and onchange handler functionality - please see those patches for details and some examples. Thanks, Tom The following changes since commit 5a5e3d3ceae2121590d67258a4e658d938b4a46d: perf probe: Support SDT markers having reference counter (semaphore) (2018-09-24 04:44:54 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/hist-snapshot-onchange-v5 Tom Zanussi (8): tracing: Refactor hist trigger action code tracing: Split up onmatch action data tracing: Generalize hist trigger onmax and save action tracing: Add conditional snapshot tracing: Move hist trigger key printing into a separate function tracing: Add snapshot action tracing: Add hist trigger onchange() handler trace: Add alternative synthetic event trace action syntax Documentation/trace/histogram.rst | 226 +++++ kernel/trace/trace.c | 162 ++- kernel/trace/trace.h | 56 +- kernel/trace/trace_events_hist.c | 1062 +++++++++++++++----- kernel/trace/trace_events_trigger.c | 2 +- kernel/trace/trace_sched_wakeup.c | 2 +- .../inter-event/trigger-onchange-action-hist.tc | 43 + .../inter-event/trigger-onmatch-action-hist.tc | 13 + 8 files changed, 1280 insertions(+), 286 deletions(-) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc -- 2.14.1