From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: Support Opensource <support.opensource@diasemi.com>,
LKML <linux-kernel@vger.kernel.org>,
Cirrus Patches <patches@opensource.cirrus.com>
Subject: [PATCH 00/13] Fix backtrace warnings from bad notifier chain calls
Date: Tue, 5 Mar 2019 17:59:57 +0000 [thread overview]
Message-ID: <cover.1551808797.git.stwiss.opensource@diasemi.com> (raw)
Hi Mark,
This patch-set fixes a WARN_ON_ONCE() backtrace call caused by not
locking the mutex from the function call regulator_notifier_call_chain().
It does this for thirteen regulator drivers by adding a mutex lock
surrounding the notifier calls.
This missing mutex lock has been around for a while, but the API I have
used used here to fix it (i.e. regulator_lock()/regulator_unlock()) has
only been in the kernel since v4.18. Therefore as this fix stands, the
patches do not port back very far in kernel history.
Regards,
Steve
Steve Twiss (13):
regulator: da9055: Fix notifier mutex lock warning
regulator: da9062: Fix notifier mutex lock warning
regulator: da9063: Fix notifier mutex lock warning
regulator: da9211: Fix notifier mutex lock warning
regulator: lp8755: Fix notifier mutex lock warning
regulator: ltc3589: Fix notifier mutex lock warning
regulator: ltc3676: Fix notifier mutex lock warning
regulator: pv88060: Fix notifier mutex lock warning
regulator: pv88080: Fix notifier mutex lock warning
regulator: pv88090: Fix notifier mutex lock warning
regulator: wm831x: Fix notifier mutex lock warning
regulator: wm831x isink: Fix notifier mutex lock warning
regulator: wm831x ldo: Fix notifier mutex lock warning
drivers/regulator/da9055-regulator.c | 2 ++
drivers/regulator/da9062-regulator.c | 2 ++
drivers/regulator/da9063-regulator.c | 5 ++++-
drivers/regulator/da9211-regulator.c | 4 ++++
drivers/regulator/lp8755.c | 15 ++++++++++++---
drivers/regulator/ltc3589.c | 10 ++++++++--
drivers/regulator/ltc3676.c | 10 ++++++++--
drivers/regulator/pv88060-regulator.c | 4 ++++
drivers/regulator/pv88080-regulator.c | 4 ++++
drivers/regulator/pv88090-regulator.c | 4 ++++
drivers/regulator/wm831x-dcdc.c | 4 ++++
drivers/regulator/wm831x-isink.c | 2 ++
drivers/regulator/wm831x-ldo.c | 2 ++
13 files changed, 60 insertions(+), 8 deletions(-)
--
1.9.3
next reply other threads:[~2019-03-05 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 17:59 Steve Twiss [this message]
2019-02-26 14:59 ` [PATCH 01/13] regulator: da9055: Fix notifier mutex lock warning Steve Twiss
2019-02-26 15:19 ` [PATCH 02/13] regulator: da9062: " Steve Twiss
2019-02-26 15:23 ` [PATCH 03/13] regulator: da9063: " Steve Twiss
2019-02-26 15:27 ` [PATCH 04/13] regulator: da9211: " Steve Twiss
2019-02-26 15:32 ` [PATCH 05/13] regulator: lp8755: " Steve Twiss
2019-02-26 15:35 ` [PATCH 06/13] regulator: ltc3589: " Steve Twiss
2019-02-26 15:38 ` [PATCH 07/13] regulator: ltc3676: " Steve Twiss
2019-02-26 15:42 ` [PATCH 08/13] regulator: pv88060: " Steve Twiss
2019-02-26 15:44 ` [PATCH 09/13] regulator: pv88080: " Steve Twiss
2019-02-26 15:46 ` [PATCH 10/13] regulator: pv88090: " Steve Twiss
2019-02-26 15:48 ` [PATCH 11/13] regulator: wm831x: " Steve Twiss
2019-03-06 9:27 ` Charles Keepax
2019-02-26 15:51 ` [PATCH 12/13] regulator: wm831x isink: " Steve Twiss
2019-03-06 9:28 ` Charles Keepax
2019-02-26 15:54 ` [PATCH 13/13] regulator: wm831x ldo: " Steve Twiss
2019-03-06 9:28 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1551808797.git.stwiss.opensource@diasemi.com \
--to=stwiss.opensource@diasemi.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome