mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@oracle.com, joe@perches.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: [PATCH 00/10] staging: rtl8723bs: completely remove RT_TRACE logs
Date: Mon,  5 Apr 2021 18:49:47 +0200	[thread overview]
Message-ID: <cover.1617640221.git.fabioaiuto83@gmail.com> (raw)

This patchset removes all RT_TRACE usages left and definitions

The whole private tracing system is not tied to a configuration
symbol and the default behaviour is _trace nothing_. It's verbose
and relies on a private log level tracing doomed to be
removed.

The patchset consist on a first patch applying the following
semantic patch on rtl8723bs directory:

$ cat RT_TRACE.cocci
@@
expression a, b, c;
@@

-       RT_TRACE(a, b, (c));

Then follows a patch removing commented out RT_TRACE calls.
Third patch removes RT_TRACE definitions.

All other patches, do some code cleaning on sites left blank
by RT_TRACE removal.

This scheme was suggested by Joe Perches.

https://lore.kernel.org/linux-staging/1cd79d781cdcccf621ce8e104a9cdf1e90e7f803.camel@perches.com/

Fabio Aiuto (10):
  staging: rtl8723bs: remove all RT_TRACE logs in hal/ and os_dep/
  staging: rtl8723bs: remove commented out RT_TRACE logs in hal/ and
    os_dep/
  staging: rtl8723bs: remove RT_TRACE log definitions
  staging: rtl8723bs: remove empty if, else blocks after RT_TRACE
    deletion
  staging: rtl8723bs: remove empty #ifdef blocks after RT_TRACE deletion
  staging: rtl8723bs: remove unnecessary bracks after RT_TRACE deletion
  staging: rtl8723bs: place constant on the right side of the test
  staging: rtl8723bs: rewrite comparisons to null
  staging: rtl8723bs: remove empty for cycles
  staging: rtl8723bs: remove commented code block

 .../staging/rtl8723bs/hal/HalPhyRf_8723B.c    |   3 -
 drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c  |  46 ------
 .../staging/rtl8723bs/hal/hal_com_phycfg.c    |  20 ---
 drivers/staging/rtl8723bs/hal/hal_intf.c      |   2 -
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 131 +-----------------
 .../staging/rtl8723bs/hal/rtl8723b_phycfg.c   |  33 -----
 .../staging/rtl8723bs/hal/rtl8723b_rf6052.c   |   2 -
 .../staging/rtl8723bs/hal/rtl8723bs_recv.c    |   5 +-
 .../staging/rtl8723bs/hal/rtl8723bs_xmit.c    |  41 +-----
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  49 +------
 drivers/staging/rtl8723bs/hal/sdio_ops.c      |  35 +----
 drivers/staging/rtl8723bs/include/rtw_debug.h |  18 ---
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c |   6 -
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    |  69 +--------
 drivers/staging/rtl8723bs/os_dep/mlme_linux.c |   4 -
 drivers/staging/rtl8723bs/os_dep/os_intfs.c   |  52 +------
 .../staging/rtl8723bs/os_dep/osdep_service.c  |   4 +-
 drivers/staging/rtl8723bs/os_dep/recv_linux.c |  12 +-
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c  |  28 +---
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c |   5 -
 20 files changed, 24 insertions(+), 541 deletions(-)

-- 
2.20.1


             reply	other threads:[~2021-04-05 16:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 16:49 Fabio Aiuto [this message]
2021-04-05 16:49 ` [PATCH 01/10] staging: rtl8723bs: remove all RT_TRACE logs in hal/ and os_dep/ Fabio Aiuto
2021-04-05 16:49 ` [PATCH 02/10] staging: rtl8723bs: remove commented out " Fabio Aiuto
2021-04-09 10:12   ` Dan Carpenter
2021-04-09 10:23     ` Fabio Aiuto
2021-04-05 16:49 ` [PATCH 03/10] staging: rtl8723bs: remove RT_TRACE log definitions Fabio Aiuto
2021-04-05 16:49 ` [PATCH 04/10] staging: rtl8723bs: remove empty if, else blocks after RT_TRACE deletion Fabio Aiuto
2021-04-05 16:49 ` [PATCH 05/10] staging: rtl8723bs: remove empty #ifdef " Fabio Aiuto
2021-04-05 16:49 ` [PATCH 06/10] staging: rtl8723bs: remove unnecessary bracks " Fabio Aiuto
2021-04-05 16:49 ` [PATCH 07/10] staging: rtl8723bs: place constant on the right side of the test Fabio Aiuto
2021-04-05 16:49 ` [PATCH 08/10] staging: rtl8723bs: rewrite comparisons to null Fabio Aiuto
2021-04-05 16:49 ` [PATCH 09/10] staging: rtl8723bs: remove empty for cycles Fabio Aiuto
2021-04-05 16:49 ` [PATCH 10/10] staging: rtl8723bs: remove commented code block Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1617640221.git.fabioaiuto83@gmail.com \
    --to=fabioaiuto83@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®