mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: jim.cromie@gmail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-modules@vger.kernel.org
Subject: [PATCH v2 0/2] dyndbg: let's use the module notifier callback
Date: Tue, 28 Feb 2023 14:34:20 -0500	[thread overview]
Message-ID: <cover.1677612539.git.jbaron@akamai.com> (raw)

Hi,

Jim Cromie hit a BUG() while toggling jump label branches in a module
before they were properly initialized. This isn't currently an issue,
but will be as part of his pending classmap series. Seems like we
should covert to using module callback notifier for dynamic debug
anyways. First patch is just a cleanup.

Link: https://lore.kernel.org/lkml/20230113193016.749791-21-jim.cromie@xxxxxxxxx/

Thanks,

-Jason

v2:
-Fix: error: field 'dyndbg_info' has incomplete type
 Reported-by: kernel test robot <lkp@intel.com>
 Link: https://lore.kernel.org/oe-kbuild-all/202302190427.9iIK2NfJ-lkp@intel.com/
-make ddebug_remove_module() static

Jason Baron (2):
  dyndbg: remove unused 'base' arg from __ddebug_add_module()
  dyndbg: use the module notifier callbacks

 include/linux/dynamic_debug.h | 13 ---------
 include/linux/module.h        |  4 +++
 kernel/module/internal.h      |  2 --
 kernel/module/main.c          | 30 ++++++---------------
 lib/dynamic_debug.c           | 51 ++++++++++++++++++++++++++++-------
 5 files changed, 53 insertions(+), 47 deletions(-)

-- 
2.17.1


             reply	other threads:[~2023-02-28 19:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 19:34 Jason Baron [this message]
2023-02-28 19:34 ` [PATCH v2 1/2] dyndbg: remove unused 'base' arg from __ddebug_add_module() Jason Baron
2023-02-28 20:38   ` Luis Chamberlain
2023-03-01  2:12     ` jim.cromie
2023-03-09 18:31   ` Vincenzo Palazzo
2023-03-09 20:58     ` Luis Chamberlain
2023-02-28 19:35 ` [PATCH v2 2/2] dyndbg: use the module notifier callbacks Jason Baron
2023-02-28 20:44   ` Luis Chamberlain
2023-02-28 21:56     ` Jason Baron
2023-02-28 23:34       ` Luis Chamberlain
2023-02-28 20:18 ` [PATCH v2 0/2] dyndbg: let's use the module notifier callback Luis Chamberlain
2023-02-28 20:28   ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1677612539.git.jbaron@akamai.com \
    --to=jbaron@akamai.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®