From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Sathvika Vasireddy <sv@linux.ibm.com>,
Naveen N Rao <naveen@kernel.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v3 00/15] powerpc/objtool: uaccess validation for PPC32 (v3)
Date: Fri, 23 Jun 2023 19:05:11 +0200 [thread overview]
Message-ID: <cover.1687539638.git.christophe.leroy@csgroup.eu> (raw)
This series adds UACCESS validation for PPC32. It includes half
a dozen of changes to objtool core.
It is almost mature, performs code analysis for all PPC32, only
missing marking of UACCESS enable/disable for book3s/32.
Most object files are correctly decoded, only a few
'unreachable instruction' warnings remain due to more complex
switch table cases:
- Loading of table address after the dynamic jump
- Nested switches
It allowed to detect some UACCESS mess in a few files. They've been
fixed through other patches.
Changes in v3:
- Rebased on top of a merge of powerpc tree and tip/objtool/core tree
- Simplified support for relative switch tables based on relocation type
- Taken comments from Peter
Christophe Leroy (15):
powerpc/kuap: Avoid unnecessary reads of MD_AP
powerpc/kuap: Avoid useless jump_label on empty function
powerpc/kuap: Refactor static branch for disabling kuap
powerpc/kuap: Make disabling KUAP at boottime impossible except on
book3s/64
powerpc/kuap: KUAP enabling/disabling functions must be
__always_inline
Revert "powerpc/bug: Provide better flexibility to
WARN_ON/__WARN_FLAGS() with asm goto"
objtool: Allow an architecture to disable objtool on ASM files
objtool: Fix JUMP_ENTRY_SIZE for bi-arch like powerpc
objtool: Add INSN_RETURN_CONDITIONAL
objtool: Add support for relative switch tables
objtool: Remove too strict constraint in jump table search
objtool: Add support for more complex UACCESS control
objtool: Prepare noreturns.h for more architectures
powerpc/bug: Annotate reachable after warning trap
powerpc: Implement UACCESS validation on PPC32
arch/Kconfig | 5 ++
arch/powerpc/Kconfig | 2 +
arch/powerpc/include/asm/book3s/32/kup.h | 39 ++++-----
arch/powerpc/include/asm/book3s/64/kup.h | 36 ++++----
arch/powerpc/include/asm/bug.h | 77 ++++-------------
arch/powerpc/include/asm/kup.h | 66 ++++++++++-----
arch/powerpc/include/asm/nohash/32/kup-8xx.h | 52 +++++-------
arch/powerpc/include/asm/nohash/kup-booke.h | 49 +++++------
arch/powerpc/include/asm/uaccess.h | 6 +-
arch/powerpc/kernel/misc_32.S | 2 +-
arch/powerpc/kernel/traps.c | 9 +-
arch/powerpc/kexec/core_32.c | 4 +-
arch/powerpc/mm/book3s32/kuap.c | 18 ++--
arch/powerpc/mm/init-common.c | 3 +
arch/powerpc/mm/nohash/kup.c | 11 +--
include/linux/objtool.h | 14 ++++
scripts/Makefile.build | 4 +
tools/objtool/arch/powerpc/decode.c | 83 +++++++++++++++++--
.../arch/powerpc/include/arch/noreturns.h | 11 +++
.../arch/powerpc/include/arch/special.h | 2 +-
tools/objtool/arch/powerpc/special.c | 34 +++++++-
.../objtool/arch/x86/include/arch/noreturns.h | 20 +++++
tools/objtool/check.c | 59 ++++++++++---
tools/objtool/include/objtool/arch.h | 1 +
tools/objtool/noreturns.h | 14 +---
tools/objtool/special.c | 55 ++++++------
26 files changed, 399 insertions(+), 277 deletions(-)
create mode 100644 tools/objtool/arch/powerpc/include/arch/noreturns.h
create mode 100644 tools/objtool/arch/x86/include/arch/noreturns.h
--
2.40.1
next reply other threads:[~2023-06-23 17:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 17:05 Christophe Leroy [this message]
2023-06-23 17:05 ` [PATCH v3 01/15] powerpc/kuap: Avoid unnecessary reads of MD_AP Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 02/15] powerpc/kuap: Avoid useless jump_label on empty function Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 03/15] powerpc/kuap: Refactor static branch for disabling kuap Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 04/15] powerpc/kuap: Make disabling KUAP at boottime impossible except on book3s/64 Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 05/15] powerpc/kuap: KUAP enabling/disabling functions must be __always_inline Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 06/15] Revert "powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto" Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 07/15] objtool: Allow an architecture to disable objtool on ASM files Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 08/15] objtool: Fix JUMP_ENTRY_SIZE for bi-arch like powerpc Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 09/15] objtool: Add INSN_RETURN_CONDITIONAL Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 10/15] objtool: Add support for relative switch tables Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 11/15] objtool: Remove too strict constraint in jump table search Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 12/15] objtool: Add support for more complex UACCESS control Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 13/15] objtool: Prepare noreturns.h for more architectures Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 14/15] powerpc/bug: Annotate reachable after warning trap Christophe Leroy
2023-06-23 17:05 ` [PATCH v3 15/15] powerpc: Implement UACCESS validation on PPC32 Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1687539638.git.christophe.leroy@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=sv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®