From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Santosh Shilimkar <ssantosh@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Jai Luthra <j-luthra@ti.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux@ew.tq-group.com,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: [PATCH 0/3] clk: keystone: syscon-clk: fixes for audio refclk
Date: Tue, 1 Aug 2023 12:36:06 +0200 [thread overview]
Message-ID: <cover.1690885413.git.matthias.schiffer@ew.tq-group.com> (raw)
Currently the driver uses of_clk_hw_onecell_get() for all clocks it
manages, but this is incorrect for the audio refclk, which has 0 rather
than 1 clock cell according to its binding documentation [1]; attempting
to look up the clock when referenced like this in the Device Tree leads
to errors, as uninitialized memory is passed to of_clk_hw_onecell_get()
as the index.
The actual fix is in patch 3; patches 1 and 2 are preparation and
related cleanup. I've added a Fixes: tag to all 3 patches, as they
need to be backported together.
Matthias Schiffer (3):
clk: keystone: syscon-clk: use struct instead of array for match data
clk: keystone: syscon-clk: specify whether a parent is required in
match data
clk: keystone: syscon-clk: use of_clk_hw_simple_get() for audio refclk
[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml
drivers/clk/keystone/syscon-clk.c | 73 ++++++++++++++++++++-----------
1 file changed, 48 insertions(+), 25 deletions(-)
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
next reply other threads:[~2023-08-01 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 10:36 Matthias Schiffer [this message]
2023-08-01 10:36 ` [PATCH 1/3] clk: keystone: syscon-clk: use struct instead of array for match data Matthias Schiffer
2023-08-01 10:36 ` [PATCH 2/3] clk: keystone: syscon-clk: specify whether a parent is required in " Matthias Schiffer
2023-08-01 10:36 ` [PATCH 3/3] clk: keystone: syscon-clk: use of_clk_hw_simple_get() for audio refclk Matthias Schiffer
2023-08-02 9:16 ` [PATCH 0/3] clk: keystone: syscon-clk: fixes " Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1690885413.git.matthias.schiffer@ew.tq-group.com \
--to=matthias.schiffer@ew.tq-group.com \
--cc=j-luthra@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®