mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Petr Mladek" <pmladek@suse.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Xiubo Li" <xiubli@redhat.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] Improve handling of -ENOMEM in dev_err_probe()
Date: Thu, 13 Jun 2024 23:23:51 +0200	[thread overview]
Message-ID: <cover.1718311756.git.u.kleine-koenig@baylibre.com> (raw)

From: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Hello,

the first patch is just a (trivial) forward port of
https://lore.kernel.org/lkml/20240412164405.335657-2-u.kleine-koenig@pengutronix.de
to today's next.

In reply to the above mentioned patch submission Andy Shevchenko
suggested to make passing -ENOMEM unconditionally to dev_err_probe()
(i.e. handling the return value of a function that can only succeed or
return -ENOMEM) a build error. I'm not convinced, but for the purpose to
show good will and get the first patch in, I implemented that in the 2nd
patch. See the comments in that mail for my concerns.

After some discussion about Andy's concern the (implicit) v1 thread
died. To get the discussion going again here comes another patch
submission for these ideas.

Best regards
Uwe

Uwe Kleine-König (2):
  driver core: Make dev_err_probe() silent for -ENOMEM
  driver core: Don't allow passing a -ENOMEM to dev_err_probe()

 drivers/base/core.c        | 21 ++++++++++++++++-----
 include/linux/dev_printk.h |  8 +++++++-
 2 files changed, 23 insertions(+), 6 deletions(-)

base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
-- 
2.43.0


             reply	other threads:[~2024-06-13 21:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13 21:23 Uwe Kleine-König [this message]
2024-06-13 21:23 ` [PATCH v2 1/2] driver core: Make dev_err_probe() silent for -ENOMEM Uwe Kleine-König
2024-06-14  7:02   ` Geert Uytterhoeven
2024-06-13 21:23 ` [PATCH RFC v2 2/2] driver core: Don't allow passing a -ENOMEM to dev_err_probe() Uwe Kleine-König
2024-06-14  7:26   ` Geert Uytterhoeven
2024-06-14  9:15     ` Uwe Kleine-König
2024-06-14 12:10       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1718311756.git.u.kleine-koenig@baylibre.com \
    --to=ukleinek@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rafael@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=xiubli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®